Skip to content

Conversation

@TomaNikolov
Copy link
Contributor

  • Add activity to the AndroidManifest. …
    • If the activity tag is not present in the AndroidManifest Cordova prepare will throw UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'attrib' of null.
  • Ensure that the support version is present in the Gradle project
  • Update demo project.

Note that the webpack workflow is not supported with this plugin

If the activity tag is not present in the AndroidManifest Cordova prepare will throw `UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'attrib' of null`
@TomaNikolov TomaNikolov added the enhancement New feature or request label Jun 13, 2019
@TomaNikolov TomaNikolov self-assigned this Jun 13, 2019
@cla-bot
Copy link

cla-bot bot commented Jun 13, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @TomaNikolov.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@cla-bot cla-bot bot removed the enhancement New feature or request label Jun 13, 2019
@TomaNikolov
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Jun 13, 2019
@cla-bot
Copy link

cla-bot bot commented Jun 13, 2019

The cla-bot has been summoned, and re-checked this pull request!

@mbektchiev mbektchiev changed the title Support {N} 5.x version Support {N} Android 5.4 version Jun 13, 2019
@TomaNikolov TomaNikolov merged commit b94d584 into master Jun 13, 2019
@TomaNikolov TomaNikolov deleted the tnikolov/5.x-support branch June 13, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants