refactor(HMR): rename module to path in context object (#787)

* refactor: rename module to path parameter * style: add a missing whitespace
NativeScript · Feb 4, 2019 · cc82df3 · cc82df3
1 parent 5950e79
commit cc82df3
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/bundle-config-loader.js b/bundle-config-loader.js
@@ -12,13 +12,13 @@ module.exports = function (source) {
                 hmrUpdate();
             };
 
-            global.hmrRefresh = function({ type, module } = {}) {
+            global.hmrRefresh = function({ type, path } = {}) {
                 if (global.__initialHmrUpdate) {
                     return;
                 }
 
                 setTimeout(() => {
-                    global.__hmrSyncBackup({ type, module });
+                    global.__hmrSyncBackup({ type, path });
                 });
             };
 

diff --git a/hot-loader-helper.js b/hot-loader-helper.js
@@ -1,9 +1,9 @@
-module.exports.reload = function ({ type, module }) {
+module.exports.reload = function ({ type, path }) {
     return `
     if (module.hot) {
         module.hot.accept();
         module.hot.dispose(() => {
-            global.hmrRefresh({ type: '${type}', module: '${module}' });
+            global.hmrRefresh({ type: '${type}', path: '${path}' });
         })
     }
 `};
diff --git a/markup-hot-loader.js b/markup-hot-loader.js
@@ -3,5 +3,5 @@ const { reload } = require("./hot-loader-helper");
 module.exports = function (source) {
     const typeMarkup = "markup";
     const modulePath = this.resourcePath.replace(this.rootContext, ".");
-    return `${source};${reload({ type: typeMarkup, module: modulePath })}`;
+    return `${source};${reload({ type: typeMarkup, path: modulePath })}`;
 };
diff --git a/script-hot-loader.js b/script-hot-loader.js
@@ -3,5 +3,5 @@ const { reload } = require("./hot-loader-helper");
 module.exports = function (source) {
     const typeScript = "script";
     const modulePath = this.resourcePath.replace(this.rootContext, ".");
-    return `${source};${reload({ type: typeScript, module: modulePath })}`;
+    return `${source};${reload({ type: typeScript, path: modulePath })}`;
 };
diff --git a/style-hot-loader.js b/style-hot-loader.js
@@ -3,5 +3,5 @@ const { reload } = require("./hot-loader-helper");
 module.exports = function (source) {
     const typeStyle = "style";
     const modulePath = this.resourcePath.replace(this.rootContext, ".");
-    return `${source};${reload({ type: typeStyle, module: modulePath })}`;
+    return `${source};${reload({ type: typeStyle, path: modulePath })}`;
 };