From 0a46180d8dab101165208ca4b1abb31665e93315 Mon Sep 17 00:00:00 2001 From: Vasil Trifonov Date: Mon, 23 Apr 2018 17:07:17 +0300 Subject: [PATCH 1/2] Read v8 version from webpack.config.js --- plugins/NativeScriptSnapshotPlugin/index.js | 1 + plugins/NativeScriptSnapshotPlugin/options.json | 3 +++ 2 files changed, 4 insertions(+) diff --git a/plugins/NativeScriptSnapshotPlugin/index.js b/plugins/NativeScriptSnapshotPlugin/index.js index 54d17047..396d7196 100644 --- a/plugins/NativeScriptSnapshotPlugin/index.js +++ b/plugins/NativeScriptSnapshotPlugin/index.js @@ -64,6 +64,7 @@ exports.NativeScriptSnapshotPlugin = (function() { targetArchs: options.targetArchs, useLibs: options.useLibs, androidNdkPath: options.androidNdkPath, + v8Version: this.options.v8Version, tnsJavaClassesPath: join(preparedAppRootPath, "tns-java-classes.js") }).then(() => { // Make the original file empty diff --git a/plugins/NativeScriptSnapshotPlugin/options.json b/plugins/NativeScriptSnapshotPlugin/options.json index fb1b0560..8587fd49 100644 --- a/plugins/NativeScriptSnapshotPlugin/options.json +++ b/plugins/NativeScriptSnapshotPlugin/options.json @@ -25,6 +25,9 @@ }, "useLibs": { "type": "boolean" + }, + "v8Version": { + "type": "string" } }, "additionalProperties": false From 5070a000627bff09efe6df5105baae6c7e7c0c9b Mon Sep 17 00:00:00 2001 From: Vasil Trifonov Date: Mon, 23 Apr 2018 17:51:09 +0300 Subject: [PATCH 2/2] use options instead of this.options --- plugins/NativeScriptSnapshotPlugin/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/NativeScriptSnapshotPlugin/index.js b/plugins/NativeScriptSnapshotPlugin/index.js index 396d7196..99e85baf 100644 --- a/plugins/NativeScriptSnapshotPlugin/index.js +++ b/plugins/NativeScriptSnapshotPlugin/index.js @@ -64,7 +64,7 @@ exports.NativeScriptSnapshotPlugin = (function() { targetArchs: options.targetArchs, useLibs: options.useLibs, androidNdkPath: options.androidNdkPath, - v8Version: this.options.v8Version, + v8Version: options.v8Version, tnsJavaClassesPath: join(preparedAppRootPath, "tns-java-classes.js") }).then(() => { // Make the original file empty