Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

fix-next(hmr): HMR log is sometimes trimmed #657

Merged
merged 2 commits into from
Sep 15, 2018
Merged

fix-next(hmr): HMR log is sometimes trimmed #657

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35e90ab
fix(hmr): HMR log is sometimes trimmed
Sep 14, 2018
947d891
Merge branch 'master' into fix-hmr-log-trim
sis0k0 Sep 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions hot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,25 +37,22 @@ function result(modules, appliedModules) {
);

if (unaccepted.length > 0) {
let message = 'The following modules could not be updated:';
log.warn('The following modules could not be updated:');

for (const moduleId of unaccepted) {
message += `\n ⦻ ${moduleId}`;
log.warn(` ⦻ ${moduleId}`);
}
log.warn(message);
}

if (!(appliedModules || []).length) {
console.info('No Modules Updated.');
} else {
const message = ['The following modules were updated:'];
console.info('The following modules were updated:');

for (const moduleId of appliedModules) {
message.push(` ↻ ${moduleId}`);
console.info(` ↻ ${moduleId}`);
}

console.info(message.join('\n'));

const numberIds = appliedModules.every(
(moduleId) => typeof moduleId === 'number'
);
Expand Down