[pbxWriter] write out build-config

involves a couple of changes to writing out quoted values with escaped
quotes inside of them - uses regex, so may be brittle

Author: alunny

lib/pbxWriter.js

@@ -3,6 +3,7 @@ var pbxProj = require('./pbxProject'),
     f = util.format,
     INDENT = '\t',
     COMMENT_KEY = /_comment$/,
+    QUOTED = /^"(.*)"$/,
     EventEmitter = require('events').EventEmitter
 
 // indentation
@@ -37,6 +38,12 @@ function pbxWriter(contents) {
     this.indentLevel = 0;
 }
 
+function escapeInternals(str) {
+    return str.replace(QUOTED, function (orig, middle) {
+        return '"' + middle.replace(/"/g, '\\"') + '"';
+    });
+}
+
 util.inherits(pbxWriter, EventEmitter);
 
 pbxWriter.prototype.write = function (str) {
@@ -129,10 +136,23 @@ pbxWriter.prototype.writeObject = function (object) {
 
         if (isArray(obj)) {
             this.writeArray(obj, key)
-        } else if (cmt) {
-            this.write("%s = %s /* %s */;\n", key, obj, cmt)
+        } else if (isObject(obj)) {
+            this.write("%s = {\n", key);
+            this.indentLevel++;
+
+            this.writeObject(obj)
+
+            this.indentLevel--;
+            this.write("};\n");
         } else {
-            this.write("%s = %s;\n", key, obj)
+            if (QUOTED.test(obj))
+                obj = escapeInternals(obj);
+
+            if (cmt) {
+                this.write("%s = %s /* %s */;\n", key, obj, cmt)
+            } else {
+                this.write("%s = %s;\n", key, obj)
+            }
         }
     }
 }

test/parser/projects/build-config.pbxproj

@@ -5,8 +5,6 @@
 	};
 	objectVersion = 45;
 	objects = {
-
-
 /* Begin XCBuildConfiguration section */
 		1D6058940D05DD3E006BFB54 /* Debug */ = {
 			isa = XCBuildConfiguration;
@@ -109,7 +107,6 @@
 			name = Release;
 		};
 /* End XCBuildConfiguration section */
-
 	};
 	rootObject = 29B97313FDCFA39411CA2CEA /* Project object */;
 }

test/pbxWriter.js

@@ -17,6 +17,25 @@ function testProjectContents(filename, test) {
     });
 }
 
+// for debugging failing tests
+function testContentsInDepth(filename, test) {
+    var myProj = new pbx(filename),
+        content = fs.readFileSync(filename, 'utf-8');
+
+    // normalize tabs vs strings
+    content = content.replace(/    /g, '\t');
+
+    myProj.parse(function (err, projHash) {
+        var written = myProj.writeSync(),
+            writtenLines = written.split('\n')
+            contentLines = content.split('\n')
+
+        test.equal(writtenLines.length, contentLines.length);
+
+        test.done();
+    });
+}
+
 exports.writeSync = {
     'should write out the "hash" test': function (test) {
         testProjectContents('test/parser/projects/hash.pbxproj', test);
@@ -29,5 +48,11 @@ exports.writeSync = {
     },
     'should write out the "two-sections" test': function (test) {
         testProjectContents('test/parser/projects/two-sections.pbxproj', test);
+    },
+    'should write out the "section-entries" test': function (test) {
+        testProjectContents('test/parser/projects/section-entries.pbxproj', test);
+    },
+    'should write out the "build-config" test': function (test) {
+        testProjectContents('test/parser/projects/build-config.pbxproj', test);
     }
 }