[pbxProject] throw parser errors correctly

Author: alunny

lib/pbxProject.js

@@ -21,16 +21,18 @@ pbxProject.prototype.parse = function (cb) {
     var worker = fork(__dirname + '/parseJob.js', [this.filepath])
 
     worker.on('message', function (msg) {
-        if (msg.code) {
+        if (msg.name == 'SyntaxError' || msg.code) {
             this.emit('error', msg);
         } else {
             this.hash = msg;
             this.emit('end', null, msg)
         }
     }.bind(this));
 
-    if (cb)
+    if (cb) {
+        this.on('error', cb);
         this.on('end', cb);
+    }
 
     return this;
 }

test/parser/projects/fail.pbxproj

@@ -0,0 +1,18 @@
+// !$*UTF8*$!
+THIS SHOULD FAIL TO PARSE
+{
+    archiveVersion = 1;
+    classes = {
+    };
+    objectVersion = 45;
+    rootObject = 29B97313FDCFA39411CA2CEA /* Project object */;
+    objects = {
+/* Begin PBXTargetDependency section */
+        301BF551109A68C00062928A /* PBXTargetDependency */ = {
+            isa = PBXTargetDependency;
+            name = PhoneGapLib;
+            targetProxy = 301BF550109A68C00062928A /* PBXContainerItemProxy */;
+        };
+/* End PBXTargetDependency section */
+    };
+}

test/pbxProject.js

@@ -55,6 +55,14 @@ exports['parse function'] = {
             test.ok(myProj.hash);
             test.done();
         })
+    },
+    'it should pass an error object back when the parsing fails': function (test) {
+        var myProj = new pbx('test/parser/projects/fail.pbxproj');
+
+        myProj.parse(function (err, projHash) {
+            test.ok(err);
+            test.done();
+        })
     }
 }