fix(pbxProject): Added error throwing for missing addTarget params. Minor refactoring of file reference object creation.

Author: sidneys

lib/pbxProject.js

@@ -218,6 +218,7 @@ pbxProject.prototype.addFramework = function(fpath, opt) {
     file.fileRef = this.generateUuid();
     file.target = opt ? opt.target : undefined;
 
+    if (this.hasFile(file.path)) return false;
 
     this.addToPbxBuildFileSection(file);        // PBXBuildFile
     this.addToPbxFileReferenceSection(file);    // PBXFileReference
@@ -1012,15 +1013,24 @@ pbxProject.prototype.addTarget = function(name, type, subfolder) {
     // Setup uuid and name of new target
     var targetUuid = this.generateUuid(),
         targetType = type,
-        targetSubfolder = subfolder,
+        targetSubfolder = subfolder || name,
         targetName = name.trim();
+        
+    // Check type against list of allowed target types
+    if (!targetName) {
+        throw new Error("Target name missing.");
+    }    
+
+    // Check type against list of allowed target types
+    if (!targetType) {
+        throw new Error("Target type missing.");
+    } 
 
     // Check type against list of allowed target types
     if (!producttypeForTargettype(targetType)) {
-        console.error ('Invalid target type: ' + targetType);
-        return false
+        throw new Error("Target type invalid: " + targetType);
     }
-
+    
     // Build Configuration: Create
     var buildConfigurationsList = [
         {
@@ -1131,31 +1141,18 @@ function pbxBuildFileObj(file) {
 }
 
 function pbxFileReferenceObj(file) {
-    var obj = Object.create(null);
-
-    obj.isa = 'PBXFileReference';
-
-    obj.name = "\"" + file.basename + "\"";
-
-    if (file.path) {
-        obj.path = "\"" + file.path.replace(/\\/g, '/') + "\"";
-    }
-
-    obj.sourceTree = file.sourceTree;
-
-    if (file.fileEncoding)
-        obj.fileEncoding = file.fileEncoding;
-
-    if (file.lastKnownFileType)
-        obj.lastKnownFileType = file.lastKnownFileType;
-
-    if (file.explicitFileType)
-        obj.explicitFileType = file.explicitFileType;
-
-    if (file.includeInIndex)
-        obj.includeInIndex = file.includeInIndex;
+    var fileObject = {
+        isa: "PBXFileReference",
+        name: "\"" + file.basename + "\"",
+        path: "\"" + file.path.replace(/\\/g, '/') + "\"",
+        sourceTree: file.sourceTree,
+        fileEncoding: file.fileEncoding,
+        lastKnownFileType: file.lastKnownFileType,
+        explicitFileType: file.explicitFileType,
+        includeInIndex: file.includeInIndex
+    };
 
-    return obj;
+    return fileObject;
 }
 
 function pbxGroupChild(file) {