Skip to content

Commit 8bebb33

Browse files
author
Anis Kadri
committed
Merge branch 'forkChanges' of https://github.com/robertoandrade/node-xcode into robertoandrade-forkChanges
2 parents 448f297 + ef65ea0 commit 8bebb33

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

lib/pbxProject.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,7 @@ pbxProject.prototype.removeFramework = function(fpath, opt) {
326326
this.removeFromFrameworkSearchPaths(file);
327327
}
328328

329+
opt = opt || {};
329330
opt.embed = true;
330331
var embeddedFile = new pbxFile(fpath, opt);
331332

test/pbxFile.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,15 +208,15 @@ exports['settings'] = {
208208

209209
'should be {ATTRIBUTES:["CodeSignOnCopy"]} if sign specified': function (test) {
210210
var sourceFile = new pbxFile('signable.framework',
211-
{ sign: true });
211+
{ embed: true, sign: true });
212212

213213
test.deepEqual({ATTRIBUTES:["CodeSignOnCopy"]}, sourceFile.settings);
214214
test.done();
215215
},
216216

217217
'should be {ATTRIBUTES:["Weak","CodeSignOnCopy"]} if both weak linking and sign specified': function (test) {
218218
var sourceFile = new pbxFile('signableWeak.framework',
219-
{ weak: true, sign: true });
219+
{ embed: true, weak: true, sign: true });
220220

221221
test.deepEqual({ATTRIBUTES:["Weak", "CodeSignOnCopy"]}, sourceFile.settings);
222222
test.done();

0 commit comments

Comments
 (0)