fix: localization group children not removed as expected

Author: KristianDD

lib/pbxProject.js

@@ -669,27 +669,35 @@ pbxProject.prototype.removePbxGroup = function(groupName, path) {
     if (!groupKey) {
         return;
     }
+
+    this.removePbxGroupByKey(groupKey, path);
+}
+
+pbxProject.prototype.removePbxGroupByKey = function(groupKey, path) {
     var group = this.getPBXGroupByKey(groupKey) || this.getPBXVariantGroupByKey(groupKey)
+
+    if (!group) {
+        return;
+    }
 
     path = path || "";
-
     var children = group.children;
 
     for(i in children) {
         var file = new pbxFile($path.join(path, children[i].comment));
         file.fileRef = children[i].value;
         file.uuid = file.fileRef;
-        this.removePbxGroup(children[i].comment, $path.join(path, children[i].comment));
-        this.removeFromPbxFileReferenceSection(file);
+        this.removePbxGroupByKey(children[i].value, $path.join(path, children[i].comment));
+        this.removeFromPbxFileReferenceSectionByUuid(children[i].value);
         this.removeFromPbxBuildFileSection(file);
         this.removeFromPbxSourcesBuildPhase(file);
     }
 
     var mainGroup = this.findMainPbxGroup();
     if(mainGroup) {
-        var mainGroupChildren = this.findMainPbxGroup().children, i;
+        var mainGroupChildren = mainGroup.children, i;
         for(i in mainGroupChildren) {
-            if (mainGroupChildren[i].comment == groupName) {
+            if (mainGroupChildren[i].value == groupKey) {
                 mainGroupChildren.splice(i, 1);
             }
         }
@@ -702,15 +710,7 @@ pbxProject.prototype.removePbxGroup = function(groupName, path) {
         section = this.hash.project.objects['PBXGroup'];
     }
 
-    for (key in section) {
-        // only look for comments
-        if (!COMMENT_KEY.test(key)) continue;
-
-        if (section[key] == groupName) {
-            itemKey = key.split(COMMENT_KEY)[0];
-            delete section[itemKey];
-        }
-    }
+    removeItemAndCommentFromSectionByUuid(section, groupKey);
 }
 
 pbxProject.prototype.addToPbxProjectSection = function(target) {
@@ -759,6 +759,12 @@ pbxProject.prototype.removeFromPbxFileReferenceSection = function(file) {
     return file;
 }
 
+pbxProject.prototype.removeFromPbxFileReferenceSectionByUuid = function(fileUuid) {
+    var section = this.pbxFileReferenceSection();
+
+    removeItemAndCommentFromSectionByUuid(section, fileUuid);
+}
+
 pbxProject.prototype.addToXcVersionGroupSection = function(file) {
     if (!file.models || !file.currentModel) {
         throw new Error("Cannot create a XCVersionGroup section from not a data model document file");