From 6f39deb069b85b628c90d7758e33961f8ee82898 Mon Sep 17 00:00:00 2001
From: Veselina Radeva <veselina.radeva@telerik.com>
Date: Fri, 6 Oct 2017 17:56:23 +0300
Subject: [PATCH 1/4] (feat): Add option for iOS image aspect ration. Default
 is `fill`.

---
 README.md              | 10 ++++++++++
 demo/app/main-page.ts  | 16 +++++++++++++---
 demo/app/main-page.xml |  2 ++
 src/imagepicker.ios.ts |  4 +++-
 src/index.d.ts         |  5 +++++
 5 files changed, 33 insertions(+), 4 deletions(-)

diff --git a/README.md b/README.md
index 9e541de..b6c04f9 100644
--- a/README.md
+++ b/README.md
@@ -122,6 +122,16 @@ context
 | albums | null | Albums from where the images are picked. |
 
 
+### Image properties
+
+Once image is picked some options can be applied to it  before it is used:
+
+| Option | Default | Description |
+| --- | --- | --- |
+| maxWidth | null | Image max width |
+| maxHeight | null | Image max height |
+| iosAspectRatio | fill | iOS only. Possible values are `fit` and `fill`. [Read more](https://developer.apple.com/documentation/photos/phimagecontentmode) |
+
 ## License
 
 2015, Telerik AD
\ No newline at end of file
diff --git a/demo/app/main-page.ts b/demo/app/main-page.ts
index 6b2ec52..1880027 100644
--- a/demo/app/main-page.ts
+++ b/demo/app/main-page.ts
@@ -4,23 +4,25 @@ import { isAndroid } from "tns-core-modules/platform";
 import * as imagepicker from "nativescript-imagepicker";
 
 let list;
+let imageSrc;
 
 export function pageLoaded(args: EventData) {
     let page = <Page>args.object;
     list = page.getViewById("urls-list");
+    imageSrc = page.getViewById("imageSrc");
 }
 
 export function onSelectMultipleTap(args) {
     let context = imagepicker.create({ mode: "multiple" });
-    startSelection(context);
+    startSelection(context, false);
 }
 
 export function onSelectSingleTap(args) {
     let context = imagepicker.create({ mode: "single" });
-    startSelection(context);
+    startSelection(context, true);
 }
 
-function startSelection(context) {
+function startSelection(context, isSingle) {
     context
         .authorize()
         .then(function() {
@@ -32,6 +34,14 @@ function startSelection(context) {
             selection.forEach(function(selected) {
                 console.log("----------------");
                 console.log("uri: " + selected.uri);
+                if(isSingle){
+                    selected.getImage({ maxWidth: 200, maxHeight: 200, iosAspectRatio: 'fit' })
+                    .then((imageSource) => {
+                        imageSrc.src = imageSource;
+                    });
+                } else {
+                    imageSrc.visibility = 'hidden';
+                }
             });
             list.items = selection;
         }).catch(function (e) {
diff --git a/demo/app/main-page.xml b/demo/app/main-page.xml
index b73788a..41d50bb 100644
--- a/demo/app/main-page.xml
+++ b/demo/app/main-page.xml
@@ -12,6 +12,8 @@
                 </GridLayout>
             </ListView.itemTemplate>
         </ListView>
+
+        <Image id="imageSrc" width="200" height="200" />
         <Button row="1" text="Pick Single" tap="onSelectSingleTap" horizontalAlignment="center" />
         <Button row="2" text="Pick Multiple" tap="onSelectMultipleTap" horizontalAlignment="center" />
     </GridLayout>
diff --git a/src/imagepicker.ios.ts b/src/imagepicker.ios.ts
index 2066177..0ab5cb2 100644
--- a/src/imagepicker.ios.ts
+++ b/src/imagepicker.ios.ts
@@ -19,6 +19,7 @@ const IMAGE_HEIGHT = 80;
 interface ImageOptions {
     maxWidth?: number;
     maxHeight?: number;
+    iosAspectRatio?: "fill" | "fit";
 }
 
 export function create(options?): ImagePicker {
@@ -344,6 +345,7 @@ class ImagePickerPH extends ImagePicker {
         return new Promise<image_source.ImageSource>((resolve, reject) => {
             let size: CGSize = options ? CGSizeMake(options.maxWidth, options.maxHeight) : PHImageManagerMaximumSize;
             let resizeMode = PHImageRequestOptions.alloc().init();
+            let aspectRatio = (options && options.iosAspectRatio && options.iosAspectRatio == 'fit') ? PHImageContentMode.AspectFit : PHImageContentMode.AspectFill;
 
             // TODO: Decide whether it is benefical to use PHImageRequestOptionsResizeModeFast
             //       Accuracy vs Performance. It is probably best to expose these as iOS specific options.
@@ -357,7 +359,7 @@ class ImagePickerPH extends ImagePicker {
             PHImageManager.defaultManager().requestImageForAssetTargetSizeContentModeOptionsResultHandler(
                 image,
                 size,
-                PHImageContentMode.AspectFit, // Scales the image so that its larger dimension fits the target size
+                aspectRatio,
                 resizeMode,
                 (createdImage, data) => {
                     if (createdImage) {
diff --git a/src/index.d.ts b/src/index.d.ts
index 21d84a0..058cc59 100644
--- a/src/index.d.ts
+++ b/src/index.d.ts
@@ -12,6 +12,11 @@ export interface ImageOptions {
      * The maximum height that the image is allowed to be.
      */
     maxHeight?: number;
+
+    /**
+     * iOS only. The image aspect ratio. Default value: fill.
+     */
+    iosAspectRatio?: "fill" | "fit";
 }
 
 export class SelectedAsset extends imageAssetModule.ImageAsset {

From c3d85a9c084d1e300953990696c08ab1452426d2 Mon Sep 17 00:00:00 2001
From: Veselina Radeva <veselina.radeva@telerik.com>
Date: Tue, 17 Oct 2017 17:38:23 +0300
Subject: [PATCH 2/4] (lint): fix lint error

---
 src/imagepicker.ios.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/imagepicker.ios.ts b/src/imagepicker.ios.ts
index 0ab5cb2..f730964 100644
--- a/src/imagepicker.ios.ts
+++ b/src/imagepicker.ios.ts
@@ -345,7 +345,7 @@ class ImagePickerPH extends ImagePicker {
         return new Promise<image_source.ImageSource>((resolve, reject) => {
             let size: CGSize = options ? CGSizeMake(options.maxWidth, options.maxHeight) : PHImageManagerMaximumSize;
             let resizeMode = PHImageRequestOptions.alloc().init();
-            let aspectRatio = (options && options.iosAspectRatio && options.iosAspectRatio == 'fit') ? PHImageContentMode.AspectFit : PHImageContentMode.AspectFill;
+            let aspectRatio = (options && options.iosAspectRatio && options.iosAspectRatio === 'fit') ? PHImageContentMode.AspectFit : PHImageContentMode.AspectFill;
 
             // TODO: Decide whether it is benefical to use PHImageRequestOptionsResizeModeFast
             //       Accuracy vs Performance. It is probably best to expose these as iOS specific options.

From 935a2631e45a6ac4521750bbd7d0673e52df46c7 Mon Sep 17 00:00:00 2001
From: Veselina Radeva <veselina.radeva@telerik.com>
Date: Tue, 17 Oct 2017 18:05:45 +0300
Subject: [PATCH 3/4] (feat): Make `fit`default option also for iOS. Bump
 version for breaking change

---
 README.md              | 2 +-
 demo/app/main-page.ts  | 2 +-
 src/imagepicker.ios.ts | 4 ++--
 src/index.d.ts         | 4 ++--
 src/package.json       | 2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/README.md b/README.md
index b6c04f9..d0cb163 100644
--- a/README.md
+++ b/README.md
@@ -130,7 +130,7 @@ Once image is picked some options can be applied to it  before it is used:
 | --- | --- | --- |
 | maxWidth | null | Image max width |
 | maxHeight | null | Image max height |
-| iosAspectRatio | fill | iOS only. Possible values are `fit` and `fill`. [Read more](https://developer.apple.com/documentation/photos/phimagecontentmode) |
+| aspectRatio | fit | iOS only. Possible values are `fit` and `fill`. [Read more](https://developer.apple.com/documentation/photos/phimagecontentmode) |
 
 ## License
 
diff --git a/demo/app/main-page.ts b/demo/app/main-page.ts
index 1880027..9310b47 100644
--- a/demo/app/main-page.ts
+++ b/demo/app/main-page.ts
@@ -35,7 +35,7 @@ function startSelection(context, isSingle) {
                 console.log("----------------");
                 console.log("uri: " + selected.uri);
                 if(isSingle){
-                    selected.getImage({ maxWidth: 200, maxHeight: 200, iosAspectRatio: 'fit' })
+                    selected.getImage({ maxWidth: 200, maxHeight: 200, aspectRatio: 'fill' })
                     .then((imageSource) => {
                         imageSrc.src = imageSource;
                     });
diff --git a/src/imagepicker.ios.ts b/src/imagepicker.ios.ts
index f730964..ad30719 100644
--- a/src/imagepicker.ios.ts
+++ b/src/imagepicker.ios.ts
@@ -19,7 +19,7 @@ const IMAGE_HEIGHT = 80;
 interface ImageOptions {
     maxWidth?: number;
     maxHeight?: number;
-    iosAspectRatio?: "fill" | "fit";
+    aspectRatio?: "fill" | "fit";
 }
 
 export function create(options?): ImagePicker {
@@ -345,7 +345,7 @@ class ImagePickerPH extends ImagePicker {
         return new Promise<image_source.ImageSource>((resolve, reject) => {
             let size: CGSize = options ? CGSizeMake(options.maxWidth, options.maxHeight) : PHImageManagerMaximumSize;
             let resizeMode = PHImageRequestOptions.alloc().init();
-            let aspectRatio = (options && options.iosAspectRatio && options.iosAspectRatio === 'fit') ? PHImageContentMode.AspectFit : PHImageContentMode.AspectFill;
+            let aspectRatio = (options && options.aspectRatio && options.aspectRatio === 'fill') ? PHImageContentMode.AspectFill : PHImageContentMode.AspectFit;
 
             // TODO: Decide whether it is benefical to use PHImageRequestOptionsResizeModeFast
             //       Accuracy vs Performance. It is probably best to expose these as iOS specific options.
diff --git a/src/index.d.ts b/src/index.d.ts
index 058cc59..0c173a7 100644
--- a/src/index.d.ts
+++ b/src/index.d.ts
@@ -14,9 +14,9 @@ export interface ImageOptions {
     maxHeight?: number;
 
     /**
-     * iOS only. The image aspect ratio. Default value: fill.
+     * iOS only. The image aspect ratio. Default value: fit.
      */
-    iosAspectRatio?: "fill" | "fit";
+    aspectRatio?: "fill" | "fit";
 }
 
 export class SelectedAsset extends imageAssetModule.ImageAsset {
diff --git a/src/package.json b/src/package.json
index 3386e69..a145be4 100644
--- a/src/package.json
+++ b/src/package.json
@@ -1,6 +1,6 @@
 {
     "name": "nativescript-imagepicker",
-    "version": "3.0.7",
+    "version": "4.0.0",
     "description": "A plugin for the NativeScript framework implementing multiple image picker",
     "repository": {
         "type": "git",

From f73267415be4b05050e82f49d0ff180de7318275 Mon Sep 17 00:00:00 2001
From: Veselina Radeva <veselina.radeva@telerik.com>
Date: Wed, 18 Oct 2017 09:52:26 +0300
Subject: [PATCH 4/4] (lint): fix lint error

---
 demo/app/main-page.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/demo/app/main-page.ts b/demo/app/main-page.ts
index 9310b47..8199a20 100644
--- a/demo/app/main-page.ts
+++ b/demo/app/main-page.ts
@@ -34,7 +34,7 @@ function startSelection(context, isSingle) {
             selection.forEach(function(selected) {
                 console.log("----------------");
                 console.log("uri: " + selected.uri);
-                if(isSingle){
+                if (isSingle) {
                     selected.getImage({ maxWidth: 200, maxHeight: 200, aspectRatio: 'fill' })
                     .then((imageSource) => {
                         imageSrc.src = imageSource;