Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chrome-downloads): update to support pie api changes #276

Merged
merged 6 commits into from Jul 22, 2019

Conversation

@jakevossen5
Copy link
Contributor

commented Jul 3, 2019

Allows selection of files that have been downloaded from chrome

PR Checklist

What is the current behavior?

#223

What is the new behavior?

You can now select files that chrome downloads

Related with: #223.

fix(chrome-downloads): update to support pie api changes
Allows selection of files that have been downloaded from chrome
@cla-bot

This comment has been minimized.

Copy link

commented Jul 3, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @jakevossen5.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@project-bot project-bot bot added this to PRs in Plugins Team Jul 3, 2019

@jakevossen5

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Jul 3, 2019

@cla-bot

This comment has been minimized.

Copy link

commented Jul 3, 2019

The cla-bot has been summoned, and re-checked this pull request!

@jakevossen5

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

This is the error from the CI

> tsc -p e2e && mocha --opts ./e2e/config/mocha.opts "--runType" "android24" "--sauceLab" "--appPath" "imagepicker-debug-js.apk"
/home/travis/build/NativeScript/nativescript-imagepicker/demo/node_modules/nativescript-dev-appium/lib/parser.js:123
        const sauceUser = options.sauceUser || process.env.SAUCE_USER || process.env.npm_config["SAUCE_USER"];
                                                                                               ^
TypeError: Cannot read property 'SAUCE_USER' of undefined

Can anyone provide some insight to why this is happening? Seems like an issue with the environment variables.

@tgpetrov
Copy link
Contributor

left a comment

Hi @jakevossen5
Thank you for the PR. I managed to successfully select an image from the Downloads directory, however I am no longer able to select an image from the Phone's camera. The getDataColumn method is currently used for both types of uri-s and your changes are causing an issue with the media type. Maybe you can extend the method with a parameter for the columns that should be used or add another that can be used only for downloads uri-s?

@jakevossen5

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

Not the most elegant solution, but that seemed to work for me. Thank you!

@jakevossen5

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

Looks like the build failed because of my mistake. I’ll look at it tomorrow.

jakevossen5 added some commits Jul 19, 2019

Merge branch 'fix_chrome_downloaded_files' of github.com:jakevossen5/…
…nativescript-imagepicker into fix_chrome_downloaded_files
@jakevossen5

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

Now it is the same TypeError: Cannot read property 'SAUCE_USER' of undefined as before. Any advice?

@tgpetrov tgpetrov referenced this pull request Jul 19, 2019
4 of 4 tasks complete
@tgpetrov
Copy link
Contributor

left a comment

@jakevossen5
Looks better now. The error you see is due to technical reasons that limit us from running our checks when a PR is created from fork. In order to have passing checks I created a new PR with your commits. Thank you again for the contribution.

@tgpetrov tgpetrov merged commit 5d77c84 into NativeScript:master Jul 22, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
verification/cla-signed
Details

Plugins Team automation moved this from PRs to Done Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.