From b7badca6485ed4832e22ac1067140083292082e1 Mon Sep 17 00:00:00 2001 From: Igor Randjelovic Date: Tue, 21 Sep 2021 03:25:20 +0200 Subject: [PATCH 1/2] feat: pass through additional args after `--` to `ns` --- packages/nx/src/builders/build/builder.ts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/packages/nx/src/builders/build/builder.ts b/packages/nx/src/builders/build/builder.ts index 463960b48..752594cac 100644 --- a/packages/nx/src/builders/build/builder.ts +++ b/packages/nx/src/builders/build/builder.ts @@ -169,9 +169,17 @@ export function runBuilder(options: BuildBuilderSchema, context: ExecutorContext nsOptions.push('--force'); } } + + // additional args after -- should be passed through + const argSeparator = process.argv.findIndex(arg => arg === '--'); + let additionalArgs; + if(argSeparator >= 0) { + additionalArgs = process.argv.slice(argSeparator + 1); + } + // console.log('command:', [`ns`, ...nsOptions, ...additionalCliFlagArgs].join(' ')); // console.log('command:', [`ns`, ...nsOptions].join(' ')); - const child = childProcess.spawn(/^win/.test(process.platform) ? 'ns.cmd' : 'ns', [...nsOptions], { + const child = childProcess.spawn(/^win/.test(process.platform) ? 'ns.cmd' : 'ns', [...nsOptions, ...additionalArgs], { cwd: projectCwd, stdio: 'inherit', }); From 8ae2b768bc2a6b40dad881009de9d0320fb3fdbe Mon Sep 17 00:00:00 2001 From: Igor Randjelovic Date: Tue, 21 Sep 2021 03:26:28 +0200 Subject: [PATCH 2/2] Update builder.ts --- packages/nx/src/builders/build/builder.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/nx/src/builders/build/builder.ts b/packages/nx/src/builders/build/builder.ts index 752594cac..d7f36e413 100644 --- a/packages/nx/src/builders/build/builder.ts +++ b/packages/nx/src/builders/build/builder.ts @@ -172,7 +172,7 @@ export function runBuilder(options: BuildBuilderSchema, context: ExecutorContext // additional args after -- should be passed through const argSeparator = process.argv.findIndex(arg => arg === '--'); - let additionalArgs; + let additionalArgs = []; if(argSeparator >= 0) { additionalArgs = process.argv.slice(argSeparator + 1); }