From b9f81e8b39c6287265a6cc6f6477de98227513f1 Mon Sep 17 00:00:00 2001 From: Dimitris - Rafail Katsampas Date: Fri, 10 Sep 2021 18:21:19 +0300 Subject: [PATCH 1/3] fix: Demo support check was broken. --- packages/plugin-tools/src/generators/remove-package/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/plugin-tools/src/generators/remove-package/index.ts b/packages/plugin-tools/src/generators/remove-package/index.ts index cb8a21f..11bb7b3 100644 --- a/packages/plugin-tools/src/generators/remove-package/index.ts +++ b/packages/plugin-tools/src/generators/remove-package/index.ts @@ -120,7 +120,7 @@ function removeFromDemoIndex(tree: Tree, type: SupportedDemoType, demoAppRoot: s resetAngularIndex(tree); resetAngularRoutes(tree); return tree; - } else if (['react', 'svelte', 'vue']) { + } else if (['react', 'svelte', 'vue'].includes(type)) { // TODO: add index page for these flavors return tree; } From e3926b1de4fe8ec9e4f2613c0eb530e5717e476e Mon Sep 17 00:00:00 2001 From: Dimitris - Rafail Katsampas Date: Fri, 10 Sep 2021 18:23:49 +0300 Subject: [PATCH 2/3] fix: Do not look for `package.json` for demo types that are not supported. --- .../plugin-tools/src/generators/remove-package/index.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/plugin-tools/src/generators/remove-package/index.ts b/packages/plugin-tools/src/generators/remove-package/index.ts index 11bb7b3..8b5bb1a 100644 --- a/packages/plugin-tools/src/generators/remove-package/index.ts +++ b/packages/plugin-tools/src/generators/remove-package/index.ts @@ -24,7 +24,7 @@ export default function (tree: Tree, schema: Schema) { const demoAppRoot = getDemoAppRoot(t); removeDemoFiles(tree, t, demoAppRoot); removeFromDemoIndex(tree, t, demoAppRoot); - updateDemoDependencies(tree, demoAppRoot); + updateDemoDependencies(tree, t, demoAppRoot); } removeSharedDemoFiles(tree); @@ -168,7 +168,11 @@ export function resetAngularRoutes(tree: Tree) { tree.write(angularRouteModulePath, angularRouteModule); } -export function updateDemoDependencies(tree: Tree, demoAppRoot: string) { +export function updateDemoDependencies(tree: Tree, type: SupportedDemoType, demoAppRoot: string) { + if (['react', 'svelte', 'vue'].includes(type)) { + return; + } + const packagePath = `${demoAppRoot}/package.json`; updateJson(tree, packagePath, (json) => { From ca6ed37804c92a6cc0d071b2e1982bcb7a706c59 Mon Sep 17 00:00:00 2001 From: Dimitris - Rafail Katsampas Date: Fri, 10 Sep 2021 18:24:56 +0300 Subject: [PATCH 3/3] chore: Added `TODO` message. --- packages/plugin-tools/src/generators/remove-package/index.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/plugin-tools/src/generators/remove-package/index.ts b/packages/plugin-tools/src/generators/remove-package/index.ts index 8b5bb1a..1424fa1 100644 --- a/packages/plugin-tools/src/generators/remove-package/index.ts +++ b/packages/plugin-tools/src/generators/remove-package/index.ts @@ -170,6 +170,7 @@ export function resetAngularRoutes(tree: Tree) { export function updateDemoDependencies(tree: Tree, type: SupportedDemoType, demoAppRoot: string) { if (['react', 'svelte', 'vue'].includes(type)) { + // TODO: add index page for these flavors return; }