New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create bootstrap tabs #70

Closed
amitguptagwl opened this Issue Jul 7, 2018 · 8 comments

Comments

Projects
None yet
3 participants
@amitguptagwl
Member

amitguptagwl commented Jul 7, 2018

  1. pen the following link : https://naturalintelligence.github.io/imglab/
  2. Click on menu icon > settings

Settings modal window should have 2 tabs: General, and Data.

Current data should be shown under General tab.

Watch for changes, or Bookmark for easy discovery.
Fund this project for new features and maintenance.
[Showcase] your project with us by raising an issue

@amitguptagwl amitguptagwl changed the title from create bootstrap 4 tabs to create bootstrap tabs Jul 7, 2018

@lopyos

This comment has been minimized.

Contributor

lopyos commented Jul 9, 2018

<div id="settings-wrapper">
    	<div id="row">
    		<div class="col-xs-4">
    			<h3>Auto Save</h3>
    		</div>
    		<div class="col-xs-4">
    			<button class="btn btn-theme">General</button>
    		</div>
    		<div class="col-xs-4">
    			<button class="btn btn-theme">Data</button>
    		</div>
    	</div>        
        <small>We auto save labeling data in browser cache.</small>
        <br>
        <div class="row">
            <div class="col-6"> 
                Syncing Interval 
                <small><i class="icon-attention-circled small" data-toggle="tooltip" title="Change how early the data should be saved in browser cache.  Set 0 to disable. Minimum value is 4 sec."></i></small>
            </div>
            <div class="col-6 float-right">
                <input  type="text" value={ appConfig.autosave.syncingInterval / 1000} size=4 onchange={changeInterval}> <small></small> seconds
            </div>
        </div>

I think that I don't have permissions to commit my changes, I just dropped here the code !! is my first contribution hope that helps.

@amitguptagwl

This comment has been minimized.

Member

amitguptagwl commented Jul 9, 2018

Though it'll be helpful. But your effort should be counted. Create on fork button on top right. Do the changes, test it and then raise a PR.

@amitguptagwl

This comment has been minimized.

Member

amitguptagwl commented Jul 10, 2018

@lopyos It looks like that your changes have added the tabs but when we press data tab, a blank page was expected.

@amitguptagwl amitguptagwl reopened this Jul 10, 2018

@lopyos

This comment has been minimized.

Contributor

lopyos commented Jul 10, 2018

@amitguptagwl for that is needed to add some jquery to hide the information that is displayed in general...and on click !!! show the information that we want.

I'm kind of asking because is my first contribution and I don't know how do you prefer the things to be done .. do you want me to use jquery?

@amitguptagwl

This comment has been minimized.

Member

amitguptagwl commented Jul 10, 2018

  1. We're already using jquery. So no problem in that.
  2. the functionality of tab is to show contents of particular section. We don't need ajax for that. The purpose of Ajax is completely different.
@Alvin-Voo

This comment has been minimized.

Collaborator

Alvin-Voo commented Aug 16, 2018

Hi @amitguptagwl. Is this what you are looking for? =)

imglab_ 70

@amitguptagwl

This comment has been minimized.

Member

amitguptagwl commented Aug 16, 2018

Yes for the starting. Later we'll add some options to Data tab.

@Alvin-Voo

This comment has been minimized.

Collaborator

Alvin-Voo commented Aug 17, 2018

@amitguptagwl Alright, I have created a PR for this. Please review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment