New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: move dlib.js to dataformaters #85

Open
amitguptagwl opened this Issue Aug 21, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@amitguptagwl
Member

amitguptagwl commented Aug 21, 2018

Only for first timers.

Move js/dlib.js to dataformaters folder. Don't forget to change the reference in index.html. And test the application if nothing is broken.

Watch for changes, or Bookmark for easy discovery.
Fund this project for new features and maintenance.
[Showcase] your project with us by raising an issue


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@coderquill

This comment has been minimized.

Show comment
Hide comment
@coderquill

coderquill Aug 23, 2018

Hey @amitguptagwl , I would like to work on this issue. I just have to move dlib.js from js to dataformaters folder and change its reference in index.html from "js/dlib.js" to "dataformaters/dlib.js",right?

coderquill commented Aug 23, 2018

Hey @amitguptagwl , I would like to work on this issue. I just have to move dlib.js from js to dataformaters folder and change its reference in index.html from "js/dlib.js" to "dataformaters/dlib.js",right?

@amitguptagwl

This comment has been minimized.

Show comment
Hide comment
@amitguptagwl

amitguptagwl Aug 24, 2018

Member

Yes. But also run the application to check there is not any error in console

Member

amitguptagwl commented Aug 24, 2018

Yes. But also run the application to check there is not any error in console

@coderquill

This comment has been minimized.

Show comment
Hide comment
@coderquill

coderquill Aug 24, 2018

Okay, will do it . Thanks!

coderquill commented Aug 24, 2018

Okay, will do it . Thanks!

@coderquill

This comment has been minimized.

Show comment
Hide comment
@coderquill

coderquill Aug 29, 2018

Hey @amitguptagwl , I have raised the PR, can you please review it?

coderquill commented Aug 29, 2018

Hey @amitguptagwl , I have raised the PR, can you please review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment