WordNet: break synset attribute "gloss" into 2 seperate attributes, definition and examples #86

Merged
merged 2 commits into from Nov 1, 2013

Projects

None yet

2 participants

@jdolitsky
Contributor

The "gloss" attribute in the callback wasn't enough for my project. I've written the code to divide them into a definition and array of examples. Merge if you wish!

jdolitsky added some commits Mar 28, 2013
@jdolitsky jdolitsky break "gloss" into definition vs. examples
The "gloss" attribute in the callback wasn't enough for my project. I've written the code to divide them into a definition and array of examples. Merge if you wish!
c99a2ec
@jdolitsky jdolitsky had tokens[1] instead of data[1] 19f9bf4
@chrisumbel
Member

Great, I'll check this out shortly.

@chrisumbel chrisumbel merged commit 3a72267 into NaturalNode:master Nov 1, 2013
@chrisumbel
Member

I merged this in, but kept the original gloss as it might be used. Thanks!

@jdolitsky
Contributor

Cool.

Just looking at this for the first time in a while, and this line:

58+ examples[k] = example.replace(/"/g,'').replace(/\s\s+/g, '');

Should probably actually be:
58+ examples[k] = examples[k].replace(/"/g,'').replace(/\s\s+/g,'');

example is never defined. Sorry about that!

Josh

On Friday, November 1, 2013, Chris Umbel wrote:

I merged this in, but kept the original gloss as it might be used. Thanks!


Reply to this email directly or view it on GitHubhttps://github.com/NaturalNode/natural/pull/86#issuecomment-27564399
.

@chrisumbel
Member

adjusted and committed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment