Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt on "quit" and "exit" commands #76

Merged
merged 5 commits into from Jul 31, 2019

Conversation

@droberson
Copy link
Contributor

commented Jun 9, 2019

Pull Request (PR) Checklist

  • I have read the CONTRIBUTING doc
  • PR is from a topic/feature/bugfix branch off the dev branch (right side)
  • PR is against the dev branch (left side)
  • Merlin compiles without errors
  • Passes linting checks and unit tests
  • Updated CHANGELOG
  • Updated README documentation (if applicable)
  • Update Merlin version number in pkg/merlin.go (if applicable)

Change Type

  • Addition
  • Bugfix
  • Modification
  • Removal
  • Security

Description

This addresses #54. Prompt a user yes/no if they type "quit" at the server's prompt.

droberson added 2 commits Jun 9, 2019
@Ne0nd0g

This comment has been minimized.

Copy link
Owner

commented Jun 9, 2019

Thanks for submitting this. I can't tell you the number of times I've accidentally quit the server trying to kill an agent.

misc improvements
handle prompts more intelligently, make ^D prompt to exit rather than breaking out of the loop and hanging, treat non-yes answers as no to avoid an annoying perpetual prompt.

@droberson droberson changed the title Dev Prompt on "quit" and "exit" commands Jun 10, 2019

Ne0nd0g added 2 commits Jul 27, 2019

@Ne0nd0g Ne0nd0g merged commit 7b7ea79 into Ne0nd0g:dev Jul 31, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.