Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reopen: "Duplicate rows added on window resize" #100

Closed
yarf opened this issue Feb 27, 2017 · 3 comments
Closed

reopen: "Duplicate rows added on window resize" #100

yarf opened this issue Feb 27, 2017 · 3 comments

Comments

@yarf
Copy link

@yarf yarf commented Feb 27, 2017

(reopening, since it's not clear whether you noticed additional commentary on #98 after it was closed)

I'm afraid the commit doesn't quite address the issue effectively -- the very next call to update(), either before or after switching back from another tab, causes the same issue to occur.

http://codepen.io/anon/pen/PpwBGV

... added an update() timer at the bottom to emulate the behavior

@NeXTs NeXTs closed this in 569c029 Mar 5, 2017
@NeXTs
Copy link
Owner

@NeXTs NeXTs commented Mar 7, 2017

@yarf Hi, did you have a chance to test this? Does it works as expected?

@yarf
Copy link
Author

@yarf yarf commented Mar 7, 2017

yup, that did it!

Do we now get a free commercial-license for being part of your QA team? ;-)

cough

@NeXTs
Copy link
Owner

@NeXTs NeXTs commented Mar 8, 2017

I glad it helped!

Uplabs is responsible for licenses, not me :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.