New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to get offsetHeight of undefined #57

Closed
vamp opened this Issue Dec 2, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@vamp

vamp commented Dec 2, 2015

Math.ceil(nodes.length / 2) not works correctly when nodes.length === 1

@NeXTs

This comment has been minimized.

Show comment
Hide comment
@NeXTs

NeXTs Dec 2, 2015

Owner

Hi Denis
That's a good catch! Thank you, I will fix and update it later today

Owner

NeXTs commented Dec 2, 2015

Hi Denis
That's a good catch! Thank you, I will fix and update it later today

@NeXTs NeXTs added the bug label Dec 2, 2015

@vamp

This comment has been minimized.

Show comment
Hide comment
@vamp

vamp Dec 2, 2015

@NeXTs, thanks!
p.s. didn't like to write some code in 3d-party scripts, so my solution was:

Clusterize.prototype.getRowsHeight = (function(underlying){
  return function(){
    var ceil = Math.ceil;
    Math.ceil = Math.floor;
    var returnValue = underlying.apply(this, arguments);
    Math.ceil = ceil;
    return returnValue;
  };
})(Clusterize.prototype.getRowsHeight)

vamp commented Dec 2, 2015

@NeXTs, thanks!
p.s. didn't like to write some code in 3d-party scripts, so my solution was:

Clusterize.prototype.getRowsHeight = (function(underlying){
  return function(){
    var ceil = Math.ceil;
    Math.ceil = Math.floor;
    var returnValue = underlying.apply(this, arguments);
    Math.ceil = ceil;
    return returnValue;
  };
})(Clusterize.prototype.getRowsHeight)

@NeXTs NeXTs closed this in 21912dc Dec 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment