Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redundant rerendering on first time scroll #83

Closed
kamax1 opened this issue Sep 15, 2016 · 5 comments
Closed

redundant rerendering on first time scroll #83

kamax1 opened this issue Sep 15, 2016 · 5 comments

Comments

@kamax1
Copy link

@kamax1 kamax1 commented Sep 15, 2016

When scrolling the table for the first time the cluster rerenders and content has bad flashing effect.

I investigated the problem. In my case problem in method getRowsHeight at line
opts.item_height = nodes[Math.floor(nodes.length / 2)].offsetHeight;
opts.item_height equals 0 during initialization (but nodes exists)
so method getClusterNum return Infinity because of division by zero

i've added hot fix

    getClusterNum: function () {
      this.options.scroll_top = this.scroll_elem.scrollTop;
      if (this.options.cluster_height == this.options.block_height) return 0;
      return Math.floor(this.options.scroll_top / (this.options.cluster_height - this.options.block_height)) || 0;
    }

now it works fine for me. Would be cool if you can fix it right way.

I'm using clusterize as directive in Vuejs framework.

@NeXTs
Copy link
Owner

@NeXTs NeXTs commented Sep 15, 2016

Hey

opts.item_height equals 0 during initialization (but nodes exists)

how this could be possible if nodes exists?
could you please create example at codepen?

@kamax1
Copy link
Author

@kamax1 kamax1 commented Sep 15, 2016

Here is an example. http://codepen.io/anon/pen/ORNagp
I've figured out that it's caused by async loading of data and changing between different states.

@NeXTs
Copy link
Owner

@NeXTs NeXTs commented Sep 15, 2016

Whoa, great catch @kamax1 !

@NeXTs NeXTs closed this in 8838614 Sep 15, 2016
@NeXTs
Copy link
Owner

@NeXTs NeXTs commented Sep 15, 2016

Just pushed v0.17.1

Try this http://codepen.io/NeXTs/pen/GjkVoO?editors=1010

Pay attention how I changed html and loaded. If your version was important to you - use it, but there would be additional height determination (because until loaded is false - vue doesn't render table so Clusterize could not determine row's height. And will actually investigate row by triggering scroll (when obviously investigation of row height during .update is preferred))

@kamax1
Copy link
Author

@kamax1 kamax1 commented Sep 16, 2016

Thank you for the fast response. Works perfectly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.