New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Calendar events - rebased #356

Closed
wants to merge 29 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@nmitsou
Collaborator

nmitsou commented Dec 9, 2015

Continuation of #310
Lets see if cirleci works now

@Neamar

This comment has been minimized.

Show comment
Hide comment
@Neamar

Neamar Dec 14, 2015

Owner

Hey there!

I've been running this build for a few days, and this morning my KISS was unable t start. Every time it loaded, it crashed with the following stack trace:

12-14 08:39:35.705 5763-5808/fr.neamar.kiss E/AndroidRuntime: FATAL EXCEPTION: AsyncTask #5
                                                              Process: fr.neamar.kiss, PID: 5763
                                                              java.lang.RuntimeException: An error occurred while executing doInBackground()
                                                                  at android.os.AsyncTask$3.done(AsyncTask.java:309)
                                                                  at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:354)
                                                                  at java.util.concurrent.FutureTask.setException(FutureTask.java:223)
                                                                  at java.util.concurrent.FutureTask.run(FutureTask.java:242)
                                                                  at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:234)
                                                                  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
                                                                  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
                                                                  at java.lang.Thread.run(Thread.java:818)
                                                               Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.String.length()' on a null object reference
                                                                  at fr.neamar.kiss.normalizer.StringNormalizer.normalizeWithMap(StringNormalizer.java:33)
                                                                  at fr.neamar.kiss.normalizer.StringNormalizer.normalize(StringNormalizer.java:94)
                                                                  at fr.neamar.kiss.loader.LoadEventPojos.doInBackground(LoadEventPojos.java:63)
                                                                  at fr.neamar.kiss.loader.LoadEventPojos.doInBackground(LoadEventPojos.java:19)
                                                                  at android.os.AsyncTask$2.call(AsyncTask.java:295)
                                                                  at java.util.concurrent.FutureTask.run(FutureTask.java:237)
                                                                  at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:234) 
                                                                  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113) 
                                                                  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588) 
                                                                  at java.lang.Thread.run(Thread.java:818) 

Seems to imply that some events can have an empty name?

Owner

Neamar commented Dec 14, 2015

Hey there!

I've been running this build for a few days, and this morning my KISS was unable t start. Every time it loaded, it crashed with the following stack trace:

12-14 08:39:35.705 5763-5808/fr.neamar.kiss E/AndroidRuntime: FATAL EXCEPTION: AsyncTask #5
                                                              Process: fr.neamar.kiss, PID: 5763
                                                              java.lang.RuntimeException: An error occurred while executing doInBackground()
                                                                  at android.os.AsyncTask$3.done(AsyncTask.java:309)
                                                                  at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:354)
                                                                  at java.util.concurrent.FutureTask.setException(FutureTask.java:223)
                                                                  at java.util.concurrent.FutureTask.run(FutureTask.java:242)
                                                                  at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:234)
                                                                  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
                                                                  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
                                                                  at java.lang.Thread.run(Thread.java:818)
                                                               Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.String.length()' on a null object reference
                                                                  at fr.neamar.kiss.normalizer.StringNormalizer.normalizeWithMap(StringNormalizer.java:33)
                                                                  at fr.neamar.kiss.normalizer.StringNormalizer.normalize(StringNormalizer.java:94)
                                                                  at fr.neamar.kiss.loader.LoadEventPojos.doInBackground(LoadEventPojos.java:63)
                                                                  at fr.neamar.kiss.loader.LoadEventPojos.doInBackground(LoadEventPojos.java:19)
                                                                  at android.os.AsyncTask$2.call(AsyncTask.java:295)
                                                                  at java.util.concurrent.FutureTask.run(FutureTask.java:237)
                                                                  at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:234) 
                                                                  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113) 
                                                                  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588) 
                                                                  at java.lang.Thread.run(Thread.java:818) 

Seems to imply that some events can have an empty name?

@nmitsou

This comment has been minimized.

Show comment
Hide comment
@nmitsou

nmitsou Dec 14, 2015

Collaborator

Is it possible? Does it have date or description? Could it be a deleted event?
Could you somehow crosscheck on calendar if there is any event on that given date?

Collaborator

nmitsou commented Dec 14, 2015

Is it possible? Does it have date or description? Could it be a deleted event?
Could you somehow crosscheck on calendar if there is any event on that given date?

nmitsou added some commits Dec 14, 2015

Merge branch 'master' into calendarRebased
Conflicts:
	app/src/main/java/fr/neamar/kiss/DataHandler.java
@nmitsou

This comment has been minimized.

Show comment
Hide comment
@nmitsou

nmitsou Dec 14, 2015

Collaborator

I cannot test but it shouldn't crash now, instead it should skip the event if title is null or something else throws exception.

It would be interesting to see what this null title event is.

Collaborator

nmitsou commented Dec 14, 2015

I cannot test but it shouldn't crash now, instead it should skip the event if title is null or something else throws exception.

It would be interesting to see what this null title event is.

@Neamar

This comment has been minimized.

Show comment
Hide comment
@Neamar

Neamar Dec 14, 2015

Owner

I'll try to have a look on this weird event soon!

Owner

Neamar commented Dec 14, 2015

I'll try to have a look on this weird event soon!

nmitsou added some commits Jan 3, 2016

Merge branch 'master' into calendarRebased
Conflicts:
	app/src/main/java/fr/neamar/kiss/DataHandler.java
	app/src/main/java/fr/neamar/kiss/SettingsActivity.java
	app/src/main/java/fr/neamar/kiss/adapter/RecordAdapter.java
	app/src/main/java/fr/neamar/kiss/result/Result.java

@nmitsou nmitsou referenced this pull request Mar 5, 2016

Closed

Second page for widget #207

@Neamar

This comment has been minimized.

Show comment
Hide comment
@Neamar

Neamar Mar 5, 2016

Owner

So, back on this one ;)

First, a bit of context.
I'm a hardcore calendar user. I have around 10 events day, and I've been using Google Calendar everyday since the last 6 years.

So my calendar is messy
calendar

But it's even worse when you work with a team.
calendar1

So, at least for me, I find the current implementation a bit lacking.
It's hard to use this PR "as-is". I'm not saying it's not working: it's fast, and except for the very last-minute changes in events, it's reliable. But it's just not an easy way for me to consume time-sensitive information, and the default limit of 15 items also means that it's sometimes hard to get a view of the current day.

That's my current reflexion on this. Sad part is, I don't have any great alternatives -- or at least, none that would not require writing a complete calendar client, and gosh that's hard (just ask Sunrise ;))

All that I know is that I don't really use "search" for my events, and have only been using !day or !week. This alone tells me a better solution is probably lurking in the shadow...

The widget may be a good first step (#207 again).

tl;dr: not sure on the status of this PR. Don't want to close, but don't feel it reached it's intended use case.

Owner

Neamar commented Mar 5, 2016

So, back on this one ;)

First, a bit of context.
I'm a hardcore calendar user. I have around 10 events day, and I've been using Google Calendar everyday since the last 6 years.

So my calendar is messy
calendar

But it's even worse when you work with a team.
calendar1

So, at least for me, I find the current implementation a bit lacking.
It's hard to use this PR "as-is". I'm not saying it's not working: it's fast, and except for the very last-minute changes in events, it's reliable. But it's just not an easy way for me to consume time-sensitive information, and the default limit of 15 items also means that it's sometimes hard to get a view of the current day.

That's my current reflexion on this. Sad part is, I don't have any great alternatives -- or at least, none that would not require writing a complete calendar client, and gosh that's hard (just ask Sunrise ;))

All that I know is that I don't really use "search" for my events, and have only been using !day or !week. This alone tells me a better solution is probably lurking in the shadow...

The widget may be a good first step (#207 again).

tl;dr: not sure on the status of this PR. Don't want to close, but don't feel it reached it's intended use case.

@nmitsou

This comment has been minimized.

Show comment
Hide comment
@nmitsou

nmitsou Mar 5, 2016

Collaborator

Damn, what's wrong with your calendar... 😃
Let's leave it open and see how it goes.

Collaborator

nmitsou commented Mar 5, 2016

Damn, what's wrong with your calendar... 😃
Let's leave it open and see how it goes.

@nmitsou

This comment has been minimized.

Show comment
Hide comment
@nmitsou

nmitsou May 3, 2016

Collaborator

i close this. i will keep it on my branch

Collaborator

nmitsou commented May 3, 2016

i close this. i will keep it on my branch

@nmitsou nmitsou closed this May 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment