Asynchronously stream requests to upstream when possible [feature] #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewDryga
commented
Jun 6, 2017
| stream_request_body(client_ref, upstream_request, conn) | ||
|
|
||
| {:error, reason} -> | ||
| {:error, reason} # TODO: return 502 |
| def dispatch(%UpstreamRequest{} = upstream_request, %Conn{method: method} = conn) do | ||
| upstream_url = UpstreamRequest.to_upstream_url!(upstream_request) | ||
|
|
||
| # TODO: find better solution that dropping this for broken HTTPBin |
| stream_request_body(client_ref, upstream_request, conn) | ||
|
|
||
| {:error, reason} -> | ||
| {:error, reason} # TODO: return 502 |
There was a problem hiding this comment.
Found a TODO tag in a comment: # TODO: return 502
| def dispatch(%UpstreamRequest{} = upstream_request, %Conn{method: method} = conn) do | ||
| upstream_url = UpstreamRequest.to_upstream_url!(upstream_request) | ||
|
|
||
| # TODO: find better solution that dropping this for broken HTTPBin |
There was a problem hiding this comment.
Found a TODO tag in a comment: # TODO: find better solution that dropping this for broken HTTPBin
|
|
||
| defp put_response_headers(conn, headers) do | ||
| headers | ||
| |> Enum.reduce(conn, fn |
There was a problem hiding this comment.
Use a function call when a pipeline is only one function long
|
Ebert has finished reviewing this Pull Request and has found:
But beware that this branch is 4 commits behind the You can see more details about this review at https://ebertapp.io/github/Nebo15/annon.api/pulls/251. |
Old implementation did buffering for any data that comes in and out of the gateway, which produce several drawbacks: 1. Memory usage was high 2. Network I/O had many peaks (read full body and then send it to upstream) 3. Higher latency (now upstream accepts connection almost instantly) 4. It was impossible to send large files, because they consumed lots of memory on gateway side. Current implementation will buffer only requests with application/json content-type, allowing Logger to save them. Future plans: - Find smarter way to log requests (by dropping secure data). - Use feature flags to async proxying JSON data.
AndrewDryga
force-pushed
the
async_requests
branch
from
22e699b
to
b279358
Compare
AndrewDryga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old implementation did buffering for any data that comes in and out of
the gateway, which produce several drawbacks:
upstream)
memory on gateway side.
Current implementation will buffer only requests with application/json
content-type, allowing Logger to save them.
Future plans: