New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build warning when compiling the app #30

Merged
merged 1 commit into from Jan 5, 2019

Conversation

Projects
None yet
3 participants
@Adzz
Copy link
Contributor

Adzz commented Jun 7, 2018

should fix this:

screen shot 2018-06-07 at 13 58 01

@AndrewDryga

This comment has been minimized.

Copy link
Member

AndrewDryga commented Jun 7, 2018

Hello, @Adzz! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 7, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling faded34 on nested-tech:fix-compilation-warnings into c92fd2e on Nebo15:master.

@AndrewDryga

This comment has been minimized.

Copy link
Member

AndrewDryga commented Jun 7, 2018

Hey @Adzz. The test won't work after your fix because we are using doctests and they are sensitive for additional spaces. I'm pretty sure there is magical fix for this (like using some sigil for doc comment), but not sure which one to use. If you can find a way to fix this - it would be awesome :).

@Adzz

This comment has been minimized.

Copy link
Contributor

Adzz commented Jun 11, 2018

Ah good point!

@AndrewDryga I can see two simple solutions, which do you prefer?

  1. Don't split the output over two lines
  2. something like this:
@error_message """
  can not resolve key MY_TEST_ENV value via adapter Elixir.Confex.Adapters.SystemEnvironment
"""
# ... more code
"""
      iex> :ok = System.delete_env("MY_TEST_ENV")
      ...> Application.put_env(:myapp, :test_var, {:system, :integer, "MY_TEST_ENV"})
      ...> #{__MODULE__}.fetch_env!(:myapp, :test_var)
      ** (ArgumentError) can't fetch value for key `:test_var` of application `:myapp`, #{@error_message}
"""

The other option is to sack of doctests, and use normal tests, but I imagine that's a no!

Sigils wont work. ~S""" means the string wont let you use escape codes, which means we can't escape a new line, which means we have to have one long line anyway.

@AndrewDryga

This comment has been minimized.

Copy link
Member

AndrewDryga commented Jun 11, 2018

Let's leave it in on long line then

@Adzz Adzz force-pushed the nested-tech:fix-compilation-warnings branch from fadedca to faded34 Jun 11, 2018

@AndrewDryga AndrewDryga merged commit c5b4e25 into Nebo15:master Jan 5, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
ebert Ebert did not find any new or fixed issues.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment