Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opts argument to resolve_env!/4 #44

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@bernardd
Copy link
Contributor

commented Aug 1, 2019

This change allows the persistent and timeout parameters on Application.put_env/4 to be used when resolving the environment with Confex.resolve_env/[1, 2]. This is handy when resolving a full environment in a Distillery release using Confex inside a config provider (see https://hexdocs.pm/distillery/extensibility/config_providers.html).

@coveralls

This comment has been minimized.

Copy link

commented Aug 1, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 3b8ae35 on hippware:put_env-opts into 903632d on Nebo15:master.

@AndrewDryga

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

Thank you @bernardd. With new Elixir releases, I'm thinking about how I can alter Confex to be handy in there too 👍 .

@AndrewDryga AndrewDryga merged commit fa436d1 into Nebo15:master Aug 2, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.