New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Elixir/dialyzer warnings #74

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Projects
None yet
3 participants
@jonnystorm
Copy link
Contributor

jonnystorm commented Feb 10, 2019

  • Fix "Collectable deprecated for non-empty lists" warnings
  • Fix erroneous node_not_running matches in Migrator
  • Fix typo in Migrator.reduce_fields/4 if statement
  • Remove erroneous error match in Table._insert/2
Fix Elixir/dialyzer warnings
* Fix typo in `Migrator.reduce_fields/4` `if` statement
* Fix "Collectable deprecated for non-empty lists" warnings
* Fix erroneous `node_not_running` matches in `Migrator`
* Fix erroneous `error` match in `Table._insert/2`
@AndrewDryga

This comment has been minimized.

Copy link
Member

AndrewDryga commented Feb 10, 2019

Hello, @jonnystorm! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

context
|> Context.get_fields_placeholders()
|> Enum.into([table_name])
[ table_name

This comment has been minimized.

@AndrewDryga

AndrewDryga Feb 10, 2019

Member

There is no whitespace around parentheses/brackets most of the time, but here there is.

@AndrewDryga

This comment has been minimized.

Copy link
Member

AndrewDryga commented Feb 10, 2019

Ebert has finished reviewing this Pull Request and has found:

  • 22 possible new issues (including those that may have been commented here).

You can see more details about this review at https://ebertapp.io/github/Nebo15/ecto_mnesia/pulls/74.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 10, 2019

Coverage Status

Coverage decreased (-0.5%) to 88.267% when pulling 9007b3a on jonnystorm:fix-warnings into de6ef5f on Nebo15:master.

@AndrewDryga

This comment has been minimized.

Copy link
Member

AndrewDryga commented Feb 15, 2019

Great job! 👍

@AndrewDryga AndrewDryga merged commit 9d1fd3b into Nebo15:master Feb 15, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage decreased (-0.5%) to 88.267%
Details
ebert Ebert has found 22 possible new issues.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment