diff --git a/.travis.yml b/.travis.yml index 6df8090..66fc16c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -9,7 +9,7 @@ services: addons: postgresql: "9.5" elixir: - - 1.3.4 + - 1.4 otp_release: - 19.0 env: diff --git a/config/.credo.exs b/config/.credo.exs index cb88e1a..182464f 100644 --- a/config/.credo.exs +++ b/config/.credo.exs @@ -8,6 +8,7 @@ }, checks: [ {Credo.Check.Design.TagTODO, exit_status: 0}, + {Credo.Check.Readability.Specs, exit_status: 0}, {Credo.Check.Readability.MaxLineLength, priority: :low, max_length: 120} ] } diff --git a/config/dogma.exs b/config/dogma.exs index 313a7e0..49f5bc0 100644 --- a/config/dogma.exs +++ b/config/dogma.exs @@ -4,7 +4,7 @@ alias Dogma.Rule config :dogma, rule_set: Dogma.RuleSet.All, exclude: [ - ~r(\Alib/api/repo/tasks.ex), # TODO: https://github.com/lpil/dogma/issues/221 + ~r(\Alib/repo/tasks.ex), # TODO: https://github.com/lpil/dogma/issues/221 ~r(\Arel/), ~r(\Adeps/), ], diff --git a/lib/processing/adapters/pay2you/transfer.ex b/lib/processing/adapters/pay2you/transfer.ex index 740701c..5202486 100644 --- a/lib/processing/adapters/pay2you/transfer.ex +++ b/lib/processing/adapters/pay2you/transfer.ex @@ -2,10 +2,11 @@ defmodule Processing.Adapters.Pay2You.Transfer do @moduledoc """ This module implements card2card and card2phone tranfsers interfaces. """ - require Logger alias Processing.Adapters.Pay2You.Error alias Processing.Adapters.Pay2You.Request - alias Repo.Schemas.{Card, CardNumber} + alias Repo.Schemas.Card + alias Repo.Schemas.CardNumber + require Logger @config Confex.get(:gateway_api, :pay2you) @card2card_upstream_uri "/Card2Card/CreateCard2CardOperation" diff --git a/lib/repo/schemas/transfer.ex b/lib/repo/schemas/transfer.ex index 8c409a3..a6cf1c3 100644 --- a/lib/repo/schemas/transfer.ex +++ b/lib/repo/schemas/transfer.ex @@ -37,7 +37,7 @@ defmodule Repo.Schemas.Transfer do greater_than_or_equal_to: limits[:amount][:min], less_than_or_equal_to: limits[:amount][:max]) |> validate_number(:fee, greater_than: 0) - |> validate_length(:description, max: 250) + |> validate_length(:description, min: 5, max: 1024) |> validate_fee(:amount, :fee, fees) |> validate_metadata(:metadata) |> validate_inclusion(:status, ["authentication", "completed", "processing", "declined", "error"]) diff --git a/mix.exs b/mix.exs index 284093e..e89a522 100644 --- a/mix.exs +++ b/mix.exs @@ -6,7 +6,7 @@ defmodule Gateway.Mixfile do def project do [app: :gateway_api, version: @version, - elixir: "~> 1.3", + elixir: "~> 1.4", elixirc_paths: elixirc_paths(Mix.env), compilers: [:phoenix] ++ Mix.compilers, build_embedded: Mix.env == :prod,