Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds map-specific skill names descriptions for Shaded Hills #4213

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

Greenjoe12345
Copy link
Contributor

@Greenjoe12345 Greenjoe12345 commented Jul 15, 2024

Description of changes

Adds some overrides for some skill names and descriptions to make them more fitting for Shaded Hills. Also removes high finance skill giving Legalease. Adds map-specific skill level names.

Why and what will this PR improve

It doesn't mention modern things like microwaves that don't exist in Shaded Hills, as well as removing references to modern jobs such as EMTs. Legalese is unwanted on shadedhills.

Authorship

Myself, Loaf

Changelog

🆑
add: Added map-specific skill level, name and description overrides for Shaded hills.
/:cl:

@MistakeNot4892 MistakeNot4892 added the work in progress This PR is under development and shouldn't be merged. label Jul 16, 2024
"Trained" = "You are good at managing accounts, keeping records, and arranging transactions. You have some familiarity with mortgages, insurance, stocks, and bonds, but may be stumped when facing more complicated financial devices.",
"Experienced" = "With your experience, you are familiar with any financial entities you may run across, and are a shrewd judge of value. More often than not, investments you make will pan out well.<BR>- You can speak and understand Legalese.",
"Master" = "You have an excellent knowledge of finance, will often make brilliant investments, and have an instinctive feel for kingdom-wide economics. Financial instruments are weapons in your hands. You likely have professional experience in the finance industry."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think narrowing the scope of these descriptions to individual trades and purchases might be the way to go.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do a pass on these later.

name = "Anatomy"
uid = "skill_anatomy"
desc = "Gives you a detailed insight of the human body. A high skill in this is required to perform surgery. This skill may also help in examining nonhuman biology."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These messages are all flavoured like xenobiology is a thing. I don't know if 'nonhuman biology' is a thing in a setting where the guys running the show are the furries.

@Greenjoe12345 Greenjoe12345 marked this pull request as ready for review July 18, 2024 15:34
Copy link
Contributor

@MistakeNot4892 MistakeNot4892 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will probably do a second pass on these, they're fine for now.

@MistakeNot4892 MistakeNot4892 added ready for review This PR is ready for review and merge. and removed work in progress This PR is under development and shouldn't be merged. labels Jul 19, 2024
@out-of-phaze out-of-phaze merged commit 4292d5e into NebulaSS13:dev Jul 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants