require consensusset to be synced to set allowance #1537

Merged
merged 1 commit into from Jan 11, 2017

Projects

None yet

3 participants

@johnathanhowell
Member

this PR adds another check to the contractor's SetAllowance method which checks of the consensus set is synced before attempting to set an allowance.

Addresses #1536

@johnathanhowell johnathanhowell require consensusset to be synced to set allowance
9a1f000
@DavidVorick
Member

Is there an easy way to test this?

@lukechampine
Member

could be done with a mocked consensus set.
Interestingly, the fact that none of the integration tests failed means that the contractor is synced in all of them.

@DavidVorick
Member

I think we are pretty careful about that actually

@DavidVorick DavidVorick merged commit 0c8cf78 into master Jan 11, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment