Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed TmTheme scope issue for monaco-editor #9

Merged
merged 1 commit into from Aug 5, 2019

Conversation

Nishkalkashyap
Copy link
Contributor

Fixes issue: zikaari/monaco-textmate#5

API maintains backward compatibility. Optionally pass editor instance to
wireTmGrammars(...args, editor) to filter for appropriate token scope.

Implementation borrowed from: zikaari/monaco-textmate#5 (comment)

Before:

monaco-textmate-old

After:

monaco-textmate-corrected

@zikaari
Copy link
Owner

zikaari commented Aug 5, 2019

Thanks, @Nishkalkashyap!

The patch will be pushed in next minor release.

Please yarn add monaco-editor-textmate again to upgrade to 2.2.0

cc @CompuIves this patch implements "proper" token scope inheritance. Token will take color of its parent scope if itself doesn't have any color mapped directly.

@zikaari zikaari merged commit 00a34e9 into zikaari:master Aug 5, 2019
@CompuIves
Copy link

This is really cool, thanks for the update @Nishkalkashyap! Also very cool that you made a CodeSandbox demo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants