Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle processing state #2286

Closed
andreasschulze opened this issue May 23, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@andreasschulze
Copy link

commented May 23, 2019

We're using acme.sh (master) and our own ACME-Server.

According to https://tools.ietf.org/html/rfc8555#section-7.1.6 there is a state "processing"
This state is not handled by acme.sh. I'll provide our fix as pull request later

@Neilpang

This comment has been minimized.

Copy link
Owner

commented May 23, 2019

andreasschulze pushed a commit to andreasschulze/acme.sh that referenced this issue May 23, 2019

@andreasschulze

This comment has been minimized.

Copy link
Author

commented May 23, 2019

Oh, maybe I used the master branch I checked out a week ago.

this is my solution, by the way: andreasschulze@93740c9

I'll try today's master branch version and report results...

@andreasschulze

This comment has been minimized.

Copy link
Author

commented May 23, 2019

the version I used did contain https://github.com/Neilpang/acme.sh/blob/master/acme.sh#L4390
so my patch is stil lrequired here.

@Neilpang

This comment has been minimized.

Copy link
Owner

commented May 23, 2019

please send the PR first.
Thanks.

@andreasschulze

This comment has been minimized.

Copy link
Author

commented May 23, 2019

Neilpang added a commit that referenced this issue May 23, 2019

Neilpang added a commit that referenced this issue May 28, 2019

sync (#2297)
* Create LICENSE.md

* remove _hostingde_parse_no_strip_whitespace function as this breaks API requests

* Fix sessionid parsing on BSD

* Make travis happy. (SC2020)

* fix for #2286

* Notify mail update (#2293)

* feat: disable e-mail validation if MAIL_NOVALIDATE is set

* fix: expose _MAIL_BIN variable

* fix: call _mail_body and _mail_cmnd directly to make sure that all used variables are exposed

* fix: update notify/mail.sh

Co-Authored-By: Matej Mihevc <zuexo@users.noreply.github.com>

* fix: remove useless echo, quote eval

Sp1l added a commit to Sp1l/acme.sh that referenced this issue Jun 2, 2019

sync (Neilpang#2297)
* Create LICENSE.md

* remove _hostingde_parse_no_strip_whitespace function as this breaks API requests

* Fix sessionid parsing on BSD

* Make travis happy. (SC2020)

* fix for Neilpang#2286

* Notify mail update (Neilpang#2293)

* feat: disable e-mail validation if MAIL_NOVALIDATE is set

* fix: expose _MAIL_BIN variable

* fix: call _mail_body and _mail_cmnd directly to make sure that all used variables are exposed

* fix: update notify/mail.sh

Co-Authored-By: Matej Mihevc <zuexo@users.noreply.github.com>

* fix: remove useless echo, quote eval

HQJaTu pushed a commit to HQJaTu/acme.sh that referenced this issue Jun 13, 2019

@Neilpang Neilpang closed this Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.