New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linode v4 API Fix #1979

Merged
merged 2 commits into from Dec 22, 2018

Conversation

Projects
None yet
3 participants
@titanofold
Copy link

titanofold commented Dec 20, 2018

Undo the mistake I made earlier.

This now introduces a new dns_linode_v4.sh module so that v3 and v4 can be used side-by-side.

Aaron W. Swenson added some commits Dec 20, 2018

Aaron W. Swenson
Revert "Update Linode API to v4"
This reverts commit 9a27b38.

Turns out, the Cloud Manager is not backward compatible, nor is the
Classic Manager forward compatible.
Aaron W. Swenson
Linode API v4 Redo
The Cloud and Classic Manager work with different APIs, and so require
a separate module, which we introduce here.

The README has also been modified to state that the two are separate
and incompatible, and provides instructions on using either.

@Neilpang Neilpang merged commit f4ba7fc into Neilpang:dev Dec 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@titanofold titanofold deleted the titanofold:linode-v4-api-fix branch Dec 22, 2018

######## Public functions #####################

#Usage: dns_linode_add _acme-challenge.www.domain.com "XKrxpRBosdIKFzxW_CT3KLZNf6q0HG9i01zxXp5CPBs"
dns_linode_add() {

This comment has been minimized.

@digitalcircuit

digitalcircuit Jan 30, 2019

Do the DNS functions need to have the _v4 suffix added, now that the filename is changed from dns_linode.shdns_linode_v4.sh..?

One person had troubles with this:

[date] It seems that your api file is not correct, it must have a function named: dns_linode_v4_add
[date] Please check log file for more details: /tmp/acme/[domain name]/acme_issuecert.log
[date] It seems that your api file doesn't define dns_linode_v4_rm
[…]
```

This comment has been minimized.

@Neilpang

Neilpang Jan 30, 2019

Owner

sorry, fixed, please try again.

Neilpang pushed a commit that referenced this pull request Jan 30, 2019

neilpang

Neilpang added a commit that referenced this pull request Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment