Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify xmpp #2407

Merged
merged 3 commits into from Sep 5, 2019

Conversation

@fgma
Copy link
Contributor

commented Jul 26, 2019

Send notifications via xmpp (using sendxmpp)

sendxmpp needs to be installed and configured for the current user running acme.sh according to https://manpages.ubuntu.com/manpages/disco/en/man1/sendxmpp.1p.html#configuration%20file

@fgma fgma force-pushed the fgma:notify-xmpp branch from 3851618 to 51e12a6 Jul 28, 2019
@fgma

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2019

@Neilpang Do you have any feedback concerning this pull request?

@Neilpang

This comment has been minimized.

Copy link
Owner

commented Aug 4, 2019

can you please update the usage here:
https://github.com/Neilpang/acme.sh/wiki/notify

And create a new issue for bug reporting ?

@fgma

This comment has been minimized.

Copy link
Contributor Author

commented Aug 4, 2019

@Neilpang I've documented it on https://github.com/Neilpang/acme.sh/wiki/notify and opened an issue for bug reporting: #2425

Let me know if there is anything left for me to do.

@Neilpang

This comment has been minimized.

Copy link
Owner

commented Aug 5, 2019

Is it possible to pass these values on commandline?

username: example
jserver: example.com
password: xxxxxxxx
@fgma

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

@Neilpang Yes, this is possible but from a security point of view I would not consider doing so as other users on the system are able to access passwords that way. See also https://unix.stackexchange.com/questions/8223/can-other-users-view-the-arguments-passed-to-a-command

@Neilpang

This comment has been minimized.

Copy link
Owner

commented Aug 11, 2019

@fgma I see but please support command line, just for optional choices.

It's possible that the user wants to use a different username/password/server from the system global default settings.

Of cause, they are optional, just for advanced users to use.

@fgma

This comment has been minimized.

Copy link
Contributor Author

commented Aug 11, 2019

@Neilpang For this use-case you can use a different configuration file for sendxmpp using

export XMPP_BIN_ARGS="-t /path/to/sendxmpprc_for_acme_sh'"

which does what you want a keeps the credentials secret.

@Neilpang Neilpang merged commit b9994e5 into Neilpang:dev Sep 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.