Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable exports for Successful Post Hook and Renew Hook calls #2431

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@mleo2003
Copy link

commented Aug 5, 2019

I have been using acme.sh to manage a few certs centrally, and upon the renew hook update endpoints as needed (HAProxy servers, ELBs in AWS, other external systems, etc). I noticed that the renew hook does not send the same variables through as the reload command. These changes should allow the renew and post install hook, upon success, to use the same variables the reload command can.

@Neilpang Neilpang merged commit c7849a4 into Neilpang:dev Aug 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mleo2003 mleo2003 deleted the mleo2003:update_renew_hooks branch Aug 6, 2019

Neilpang added a commit that referenced this pull request Aug 11, 2019

sync (#2436)
* fix #2409 (#2430)

* Add variable exports for Successful Post Hook and Renew Hook calls (#2431)

* fixed json parse regex for support api gcore_cdn (#2381)

Neilpang added a commit that referenced this pull request Aug 11, 2019

sync (#2437)
* fix #2409 (#2430)

* Add variable exports for Successful Post Hook and Renew Hook calls (#2431)

* fixed json parse regex for support api gcore_cdn (#2381)

* start 2.8.3 Forbidden sudo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.