Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issuing certs #2559

Closed
wants to merge 1 commit into from
Closed

Fix issuing certs #2559

wants to merge 1 commit into from

Conversation

@nunziotocci
Copy link

nunziotocci commented Oct 25, 2019

I encountered a few problems after updating to new newest acme.sh. (platform: Fedora 24)

First, I was getting "KeyID header contained an invalid account URL", because the "location:" wasn't getting stripped out of the KeyID header.
Next, I got an error where it didn't want to recognize the "authorizations" part of the JSON response. I fixed this by stripping newlines before searching for it.
Finally, it wasn't recognizing the "valid" status because there was a space after the colon ("status": "valid" instead of "status":"valid").

I've tried to only use features that are used elsewhere in acme.sh to maintain compatibility with dash and sh, but I haven't tested with anything other than bash.

I encountered a few problems after updating to new newest acme.sh.

First, I was getting "KeyID header contained an invalid account URL", because the "location:" wasn't getting stripped out of the KeyID header.
Next, I got an error where it didn't want to recognize the "authorizations" part of the JSON response. I fixed this by stripping newlines before searching for it.
Finally, it wasn't recognizing the "valid" status because there was a space after the colon (`"status": "valid"` instead of `"status":"valid"`).

I've tried to only use features that are used elsewhere in acme.sh to maintain compatibility with dash and sh, but I haven't tested with anything other than bash.
@Neilpang

This comment has been minimized.

Copy link
Owner

Neilpang commented Oct 26, 2019

which CA did you use to test?

Can you please give me a --debug 2 log ?

@nunziotocci

This comment has been minimized.

Copy link
Author

nunziotocci commented Jan 11, 2020

Well you've probably fixed it by now, but I tested with this PR production CA and I've been using this PR since I submitted it. See attached for the log of the errors I get using the old version.

acme.log

@Neilpang

This comment has been minimized.

Copy link
Owner

Neilpang commented Jan 12, 2020

fixed. please try again with the latest dev branch:

acme.sh --upgrade -b dev
@Neilpang Neilpang closed this in 0712e98 Jan 12, 2020
@nunziotocci

This comment has been minimized.

Copy link
Author

nunziotocci commented Jan 12, 2020

Still no Joy. See attached.

acme.log.txt

@Neilpang

This comment has been minimized.

Copy link
Owner

Neilpang commented Jan 13, 2020

remove the file first:

rm .acme.sh/ca/acme-v02.api.letsencrypt.org/ca.conf
@nunziotocci

This comment has been minimized.

Copy link
Author

nunziotocci commented Jan 13, 2020

That worked, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.