Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #2596

Merged
merged 41 commits into from Nov 19, 2019
Merged

Dev #2596

merged 41 commits into from Nov 19, 2019

Conversation

@Neilpang
Copy link
Owner

Neilpang commented Nov 19, 2019

sync

stilez added 30 commits Oct 26, 2019
(( ... isn't it annoying that basic regex has * but not + ..... ))
Maybe BRE aren't as basic as they sound. But I'm sure `man grep` didn't list the extra syntax of "preceded by backslash" :)  So let's use it
…name")
stilez and others added 11 commits Nov 5, 2019
fix
Create DNS 01 module for Plesk XML API
Fixes #1586  
Check force manual switch before causing error about it.
Issue1586 - Fix callhook error in manual mode
DOCS: typo in notify/mailgun.sh  (sandbox)
In _debug_bash_helper use eval as we are seeing issues with busybox
systems having issues with array access. Even though they aren't
actually running the code they appear to be parsing it and failing.

Also older versions of busybox have a bug with eval and double quotes,
so make sure to use single quotes when using eval.

Resolves: #2579
debug_bash_helper: Use eval as busybox systems have problems
neilpang
@Neilpang Neilpang merged commit ef15e55 into master Nov 19, 2019
2 checks passed
2 checks passed
ci/dockercloud Your image was successfully built in Docker Hub
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.