Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service app start test #349

Merged

Conversation

Lachlan-S
Copy link
Collaborator

Change Description

Add a test that tests if dab app start starts service apps on their standard ports

Relevant Issue(s)

@Nekroze
Copy link
Owner

Nekroze commented Mar 1, 2019

This will display port exposures as they are currently displayed. This weekend I am doing a rewrite of ishmael address and add random port maps for web based services. The idea is to fix apps access from the local machine on Mac which requires a port bind.

At that time the ports displayed to the user that is being checked by this test will only be http addresses the user may wish to access directly. What we should be testing though is that the container itself exposes its standard service port to other containers, no neccesarily to the host. As an example if I start postgres it might be fine to not display the address as it is the default port and hostname is postgres but I want to see the address and port for pgweb so I can interact with the postgres over the network.

Still not entirely sure what it will end up looking like though so we can re-evaluate this after those changes... or if you can merge them first then I guess I have to fix the test at the same time :).

@Nekroze
Copy link
Owner

Nekroze commented Mar 3, 2019

3 new circle CI jobs must now complete in order to be able to merge a PR. Please debase this patch on master in order to pull in these tests.

@Lachlan-S Lachlan-S force-pushed the app-port-services-check branch 2 times, most recently from b74babf to d430bbd Compare March 6, 2019 04:13
@Nekroze
Copy link
Owner

Nekroze commented Mar 7, 2019

Looking real good, my only concern is that the containers are not stopped and could cause any tests this scenario to be flakey in CI where resources are limited.

Tests if `dab app start` starts service apps on their standard ports
@Lachlan-S
Copy link
Collaborator Author

That is a good point, that I had not thought about. I have updated the test to specifically stop the apps after the regex has successfully been checked.

@Nekroze
Copy link
Owner

Nekroze commented Mar 11, 2019

nice work

@Nekroze Nekroze merged commit b1eb9b4 into Nekroze:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants