Remove workaround in powermod(::FqPolyRingElem, ::ZZRingElem, ::FqPolyRingElem) - #1996
Merged
Merged
Conversation
::FqPolyRingElem)`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1996 +/- ##
==========================================
- Coverage 88.34% 88.29% -0.06%
==========================================
Files 98 98
Lines 36211 36209 -2
==========================================
- Hits 31991 31969 -22
- Misses 4220 4240 +20 ☔ View full report in Codecov by Sentry. |
fingolfin
approved these changes
Jan 29, 2025
fingolfin
added
the
release notes: not needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix in flintlib/flint#1261 has been released as part of FLINT 3.0.0, so we can assume it arrived in Nemo.