Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Enable Multiple GRF #5

Closed
admkakaroto opened this issue Jan 16, 2021 · 16 comments
Closed

[BUG] Enable Multiple GRF #5

admkakaroto opened this issue Jan 16, 2021 · 16 comments
Assignees
Labels
bug

Comments

@admkakaroto
Copy link

@admkakaroto admkakaroto commented Jan 16, 2021

Describe the bug
It's a very simple bug, when using the 'Read Multigrf' patch on client version 2020-09-02bRagexeRE, it applies without error, but it doesn't work.

To Reproduce
Steps to reproduce the behavior:

  1. Just apply the patch on the informed client version, try to read more than 5 grf's, it won't.

I didn't get to test with less than 3 grfs.

Additional Details (Complete all relevant items below)

  • Patch/Extension name: Enable Multiple GRF
  • Build Dates affected: 2020-09-02bRagexeRE
  • OS: Win10 x 64
@admkakaroto admkakaroto added the bug label Jan 16, 2021
@Neo-Mind Neo-Mind self-assigned this Jan 17, 2021
@Neo-Mind
Copy link
Owner

@Neo-Mind Neo-Mind commented Jan 20, 2021

@admkakaroto Just now tested the patch. It's working fine for me, I used a DATA.INI with 7 grfs.
Please make sure you are using the latest commit and check again.

@Neo-Mind Neo-Mind added the need feedback label Jan 20, 2021
@admkakaroto
Copy link
Author

@admkakaroto admkakaroto commented Jan 20, 2021

@admkakaroto Just now tested the patch. It's working fine for me, I used a DATA.INI with 7 grfs.
Please make sure you are using the latest commit and check again.

Ok, i'm at work now, but in 2 hours i will come to home, so, i will test this, thanks.

@Neo-Mind
Copy link
Owner

@Neo-Mind Neo-Mind commented Jan 20, 2021

In case you didn't know, the file names in DATA.INI should be numbered according to priority.
Lower numbered ones override the higher numbers.

This is especially important because official grfs would have client info inside so your grfs need to be set with a lower number than them.

@Neo-Mind
Copy link
Owner

@Neo-Mind Neo-Mind commented Jan 21, 2021

@admkakaroto any update?

@admkakaroto
Copy link
Author

@admkakaroto admkakaroto commented Jan 21, 2021

@Neo-Mind Oops, I apologize for the delay, I had personal problems and so I couldn't answer.

Well, I updated WARP:
a111

I added encryption on the client using the GRF Editor.
But when I tried to log in, the problem persists.
a222

To make sure that the problem is with reading the grfs, I will merge in ALL the grfs, use only one single grf, I will give a feedback here in a few minutes.

@admkakaroto
Copy link
Author

@admkakaroto admkakaroto commented Jan 21, 2021

Well, I put all the grf's in one, it didn't work.

So I removed the encryption from the GRF/Client and then it was possible to login.

a222

@Neo-Mind
Copy link
Owner

@Neo-Mind Neo-Mind commented Jan 22, 2021

That sounds like an issue with the way the encrypted files are being read rather than the patch itself.

Did you generate the DLL file and use that? or only did the Encryption part?

For decrypting, the client needs the DLL and the client itself would need modification in case the DLL's name is different.

@admkakaroto
Copy link
Author

@admkakaroto admkakaroto commented Jan 22, 2021

Yes, I used the file to decrypt, I haven't tested it with several unencrypted grfs, but I will test it here, yesterday I tested it with only 2 unencrypted grfs.

@admkakaroto
Copy link
Author

@admkakaroto admkakaroto commented Jan 22, 2021

I tested with several grfs, all without encryption, well, I managed to login to the character selection screen, I couldn't get into the game, but I believe there is a problem with encryption. Using the old Nemo updated by 4144, I can log into the game normally, but without encryption.

@Neo-Mind
Copy link
Owner

@Neo-Mind Neo-Mind commented Jan 25, 2021

Yea you should inform Tokei about the issue with Encryption.
Looks like the client might be expecting a newer version of CPS.

@Neo-Mind Neo-Mind removed the need feedback label Jan 25, 2021
@admkakaroto
Copy link
Author

@admkakaroto admkakaroto commented Jan 25, 2021

I will try to call Tokei to this issue.

@admkakaroto
Copy link
Author

@admkakaroto admkakaroto commented Jan 25, 2021

@SirHaziel
Copy link
Collaborator

@SirHaziel SirHaziel commented Jan 30, 2021

@admkakaroto would you be so kind to contact me on Discord?

@admkakaroto
Copy link
Author

@admkakaroto admkakaroto commented Jan 31, 2021

Sure!

@Neo-Mind
Copy link
Owner

@Neo-Mind Neo-Mind commented Feb 23, 2021

Since the issue isn't specific to WARP. Shall I close this?

@admkakaroto
Copy link
Author

@admkakaroto admkakaroto commented Feb 24, 2021

Since the issue isn't specific to WARP. Shall I close this?

Yes

@Neo-Mind Neo-Mind closed this Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug
Projects
None yet
Development

No branches or pull requests

3 participants