Fix missing script sound entries for VPK build#1950
Merged
Conversation
sunzenshen
reviewed
Apr 18, 2026
sunzenshen
previously approved these changes
Apr 18, 2026
sunzenshen
left a comment
Contributor
There was a problem hiding this comment.
Assuming parity with OGNT
AdamTadeusz
previously approved these changes
Apr 25, 2026
This commit is a verbatim copy of the OGNT file. Added for supporting the move to asset VPK mounting.
Fix error: Failed to load custom font file 'resource/hl2mp.ttf' This is unrelated to the VPK changes but might as well fix the console warning.
Already exists in game_sounds_ui.txt as HUD.JinraiWin, etc. Also, we typically call these directly with the sound filename because the volume level must correspond to "snd_victory_volume" cvar.
No SFX for rank up/down
6744e99 to
c71c8ab
Compare
This reverts commit 46a18bc. Revert removal of the unused rankup/rankdown sfx as per Discord discussion.
Member
Author
|
Rebased to master and reverted the removal of |
DESTROYGIRL
approved these changes
Jun 3, 2026
AdamTadeusz
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Address the script sound problem at #1053 (comment) by manually bringing in the relevant entries from OGNT scripts.
Fixes (among other things) the following sound errors:
The added
game_sounds_player.txtfile is verbatim from OGNT definitions, except for:Victory.Jinrai, ...entries, because we instead define them asHUD.JinraiWin, ...(and also call them directly in code due to needing to adjust the volume based on the jingle volume cvar so we can't rely on a hardcoded script volume)This includes some HL2/"shared" definitions as they are in OGNT; I figured we probably want to support these for map compat, even if things like the geiger counter sounds aren't directly relevant, so they are not removed from
game_sounds_player.txt. And some of the shared sounds we definitely want, such as the weapon pickup SFX.Other minor changes:
HL2MPTypeDeathfont nag - we don't use this HL2MP kill icon font for anything so I simply removed it entirelyHUD.GhostPickUpg_pChannelNamesvalues - these are mostly unused because the closed Valve dlls have them compiled in the binary, but might as well make our implementation match them correctlySteps to test
Upon loading into the map:
Before this patch
PrecacheScriptSound ... failed, no such sound script entryerrors, and those erroring sounds don't playWith this patch
game/neo/scripts/game_sounds_player.txtand other modified assets to the Steam app pathToolchain
Linked Issues