Skip to content

Don't sort cloaked players with translucent entities when they're drawn opaque in thermals#1966

Merged
AdamTadeusz merged 4 commits into
NeotokyoRebuild:masterfrom
AdamTadeusz:362_fixcloakedplayerrenderinginthermals
Jun 5, 2026
Merged

Don't sort cloaked players with translucent entities when they're drawn opaque in thermals#1966
AdamTadeusz merged 4 commits into
NeotokyoRebuild:masterfrom
AdamTadeusz:362_fixcloakedplayerrenderinginthermals

Conversation

@AdamTadeusz

@AdamTadeusz AdamTadeusz commented May 17, 2026

Copy link
Copy Markdown
Contributor

Description

This PR was made to address the following problem
https://discord.com/channels/1235346473827434517/1235349179296120946/1505292044963156141
however I'm struggling to replicate it on master now. Either way it doesn't make sense to render cloaked players with other translucent entities when they're not actually using the cloaked material override

Toolchain

  • Windows MSVC VS2022

Linked Issues

  • fixes #
  • related #

@AdamTadeusz AdamTadeusz marked this pull request as draft May 17, 2026 20:50
@AdamTadeusz AdamTadeusz changed the title fix player rendering when cloaked and in eye player is using thermals Don't sort cloaked players with translucent entities when they're drawn opaque in thermals Jun 4, 2026
@AdamTadeusz AdamTadeusz marked this pull request as ready for review June 4, 2026 10:57
@AdamTadeusz AdamTadeusz requested a review from a team June 4, 2026 10:57
@Rainyan Rainyan requested a review from a team June 5, 2026 07:05

@Agiel Agiel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably fine to merge this for now, but isn't this something that would affect motion vision as well?

@AdamTadeusz

Copy link
Copy Markdown
Contributor Author

Probably fine to merge this for now, but isn't this something that would affect motion vision as well?

cloaked players are always drawn transparent in motion vision, both the player model and the motion model material override

@Agiel

Agiel commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

I thought they weren't transparent when moving 🤔

@AdamTadeusz

Copy link
Copy Markdown
Contributor Author
motionVision.mp4

Nah its transparent innit

@Agiel

Agiel commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Cool, nvm me then 👀

@AdamTadeusz

AdamTadeusz commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

practically it may as well be opaque though

@AdamTadeusz AdamTadeusz merged commit b4f3383 into NeotokyoRebuild:master Jun 5, 2026
7 checks passed
@AdamTadeusz AdamTadeusz deleted the 362_fixcloakedplayerrenderinginthermals branch June 5, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants