Don't sort cloaked players with translucent entities when they're drawn opaque in thermals#1966
Merged
AdamTadeusz merged 4 commits intoJun 5, 2026
Conversation
Rainyan
approved these changes
Jun 5, 2026
Agiel
approved these changes
Jun 5, 2026
Agiel
left a comment
Contributor
There was a problem hiding this comment.
Probably fine to merge this for now, but isn't this something that would affect motion vision as well?
Contributor
Author
cloaked players are always drawn transparent in motion vision, both the player model and the motion model material override |
Contributor
|
I thought they weren't transparent when moving 🤔 |
Contributor
Author
motionVision.mp4Nah its transparent innit |
Contributor
|
Cool, nvm me then 👀 |
Contributor
Author
|
practically it may as well be opaque though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR was made to address the following problem
https://discord.com/channels/1235346473827434517/1235349179296120946/1505292044963156141
however I'm struggling to replicate it on master now. Either way it doesn't make sense to render cloaked players with other translucent entities when they're not actually using the cloaked material override
Toolchain
Linked Issues