Fix dispensers and bubble columns #18
Fixes two issues:
Also improves flow logic. See https://hub.spigotmc.org/jira/browse/SPIGOT-4759 for more information on why the jankiness is necessary.
You're right: that should set the metadata to false, not remove it. I made the distinction between a block having no safety metadata and a block having metadata set to
I did not get a chance to add the logging so as of right now the two states are basically isomorphic, but it should probably be changed for clarity. Let me know if you would like me to make that change and I will push another commit.
Right, now I understand why
The specific thing I was picking up on was that in the former link you're removing all metadata associated with SafeBuckets, regardless of key, whereas in the latter you are removing only a specific key. So the former is a future bug if other SafeBuckets keys are added.
So if there's no compelling reason to remove all those keys (all one of them), let's get L130-132 as just:
I think I'd be happy with just getting this fix through first. There are other problems in SafeBuckets that would be better to be fixed before trying to add new functionality.
Sure thing, I'll get that pushed shortly.
Just to clarify re: logging, I was speaking in the past perfect tense: it was a feature I planned approximately a year ago now that never fully came to fruition. I wasn't trying to stage for it here. To be honest I don't quite remember why I opted to remove all the block metadata instead of just setting it to false, which makes more sense here. Regardless, you're right: it's a future bug waiting to happen.
And re: the other bugs, could you open issues for those so I can help fix them? If you don't have the time to open issues for each, feel free to send me a list and I will open them.
Last but not least, thanks for taking the time to review this pull req. Let me know if there's anything I can do differently moving forward to help facilitate the review process.