Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(taro-h5): support fileName parameter when using Taro.uploadFile api (#7377) #8112

Closed
wants to merge 1 commit into from
Closed

fix(taro-h5): support fileName parameter when using Taro.uploadFile api (#7377) #8112

wants to merge 1 commit into from

Conversation

ZeroTo0ne
Copy link
Contributor

这个 PR 做了什么? (简要描述所做更改)
H5 环境下 Taro.uploadFile api 支持 fileName 参数（fix: #7377）

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id Taro.uploadFile根本不支持fileName参数 #7377
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用，不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

其它需要 Reviewer 或社区知晓的内容：

@taro-bot2 taro-bot2 bot mentioned this pull request Nov 28, 2020
Closed
@Chen-jj Chen-jj added the V-3 Version - 3.x label Dec 11, 2020
@taro-bot2 taro-bot2 bot mentioned this pull request Dec 12, 2020
Closed
ZakaryCode
ZakaryCode reviewed Dec 12, 2020
View reviewed changes
Copy link
Contributor

@ZakaryCode ZakaryCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改变更将不会在 Taro 中同步，理由如下：

  • 改变更和小程序官方的 API 接口不一致，将会加重开发者的心智负担
  • fileName 和 name 两个字段重复，实质上是同一内容
  • 如果需要使用 fileName 或者新增其他文件信息，应该在 formData 中设置

@ZakaryCode ZakaryCode closed this Dec 12, 2020
@ZakaryCode ZakaryCode mentioned this pull request Dec 12, 2020
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZakaryCode ZakaryCode ZakaryCode left review comments

Assignees
No one assigned
Labels
V-3 Version - 3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Taro.uploadFile根本不支持fileName参数
3 participants
@ZeroTo0ne @ZakaryCode @Chen-jj