Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curve Interface Hierarchy #3

Closed
NetCal opened this issue Mar 28, 2018 · 2 comments
Closed

Curve Interface Hierarchy #3

NetCal opened this issue Mar 28, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@NetCal
Copy link
Owner

NetCal commented Mar 28, 2018

Currently, the generic Interfaces for ArrivalCurve, ServiceCurve and MaxServiceCurve extend CurvePwAffine. I.e., they are in the third level of the hierarchy (see attached image taken from the ECRTS Paper of @phschon and @sbondorf). Thus they carry information about semantics and shape. They should move one level up. Then, for example, a piece-wise affine arrival curve has to implement the interfaces ArrivalCurve and PwAffineCurve.

uml_curve_hierarchy_white

@sbondorf sbondorf added the enhancement New feature or request label Apr 5, 2018
@sbondorf
Copy link
Collaborator

sbondorf commented Apr 6, 2018

After merging #5 into the v2.5 branch, we have the desired hierarchy. Yet, the PMOO left-over service curve that uses affine curves internally will now always create instances of our DNC curves to work with. Thus, we do not have an MPA-RTC-only code path. Can we bring this feature back by letting CurvePwAffine extend CurveAffine and replace curves.dnc_affine.AffineCurve_DNC with curves.CurveAffine in the PMOO analysis?

@matyesz
Copy link
Collaborator

matyesz commented Apr 7, 2018

Let me check this, when I introduced AffineCurves next to original PWAffineCurves with DNC a lot of tests started to fail with calculations using AffineCurves. Is that OK? Will correct PMOO I think the hierarchy should not be touched at the moment. Opened issue #11.

@matyesz matyesz closed this as completed Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants