Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pom.xml #7

merged 3 commits into from Apr 9, 2019


None yet
3 participants
Copy link

commented Apr 2, 2019

Remove an occurrence of calculator in pom.xml
Also added a script to easily run the program, without having to look up how to compile and run.

@NetCal NetCal requested review from scriptkitty and NetCal Apr 2, 2019

Copy link

left a comment

Thank you for fixing pom.xml!

Can you extend to the script such that

  • the version number is not hard-coded.
  • it checks for the jar file, not the target directory.
  • it includes a header explaining that it does not recompile the (potentially changed) SNC sources with every execution.
detect version
check for jar-file rather than target directory

@NetCal NetCal self-requested a review Apr 8, 2019


NetCal approved these changes Apr 8, 2019


This comment has been minimized.

Copy link

commented Apr 8, 2019

Looks good to me (yet I do not have a machine with Maven command line tools).

@sbondorf sbondorf merged commit f4c81c8 into NetCal:master Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.