fix bug for spawn args wrong position #226

Merged
merged 1 commit into from May 29, 2013

Conversation

Projects
None yet
3 participants
@jiangzhuo
Contributor

jiangzhuo commented May 28, 2013

based on http://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options

args(eg: --debug=port) should be first element in the options array.

this pull request will fix a bug mentioned at http://nodejs.netease.com/topic/515251b97f53b3d3330025c7#519eff6a3e8b1fca031b90f1

changchang added a commit that referenced this pull request May 29, 2013

Merge pull request #226 from jiangzhuo/fix-spawn-args-bug
fix bug for spawn args wrong position

@changchang changchang merged commit 9e55206 into NetEase:master May 29, 2013

@changchang

This comment has been minimized.

Show comment
Hide comment
@changchang

changchang May 29, 2013

Contributor

Thanks for pull request.

Contributor

changchang commented May 29, 2013

Thanks for pull request.

@JiaoMing

This comment has been minimized.

Show comment
Hide comment
@JiaoMing

JiaoMing Jun 3, 2013

No, @jiangzhuo it still dosn‘ work. !!!

No, @jiangzhuo it still dosn‘ work. !!!

This comment has been minimized.

Show comment
Hide comment
@JiaoMing

JiaoMing Jun 3, 2013

jiangzhuo is great! . the problem has bean resoloved.
The argument "args": "--debug=32312" is without space.

jiangzhuo is great! . the problem has bean resoloved.
The argument "args": "--debug=32312" is without space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment