Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M5: Error dialogues on reporter inputs #1028

Merged
merged 3 commits into from May 2, 2016

Conversation

mrerrormessage
Copy link
Contributor

First off: Error dialogues on reporter inputs! Cool!

However, there are a few issues.

  • You always get an error when initially creating the input. It should give you a chance to enter text.
  • More importantly, if you have an error, switch to another window, and switch back, the error keeps repeating, effectively locking you out of NetLogo.

@qiemem qiemem added the bug label Apr 25, 2016
@qiemem qiemem added this to the Hexy Honeycomb milestone Apr 25, 2016
@qiemem
Copy link
Member Author

qiemem commented Apr 25, 2016

Actually, I'm questioning how desirable syntax errors in reporter/command inputs are. It prevents some uses of them that were previously okay. For instance, if you're planning on transforming the expression before execution, or planning on running the code in a different model (something I do with reporter/command inputs in LevelSpace all the time).

@SethTisue
Copy link
Collaborator

I'm questioning how desirable syntax errors in reporter/command inputs are

maybe make it a checkbox?

@qiemem
Copy link
Member Author

qiemem commented Apr 26, 2016

maybe make it a checkbox?

In the input editing dialogue? Good idea.

@mrerrormessage
Copy link
Contributor

Did the reporter inputs ever error in 5.3.1 and earlier? I haven't found a way to make them error yet. I think the suggestions above are terrific ideas.

@qiemem
Copy link
Member Author

qiemem commented Apr 26, 2016

No, they did not.

@mrerrormessage
Copy link
Contributor

We're going to have to delay the checkbox idea until we have the new file format, unfortunately, since it won't save in the current format. 😜

@mrerrormessage mrerrormessage merged commit 7aba7c2 into hexy May 2, 2016
@mrerrormessage mrerrormessage deleted the wip-error-reporter-dialogs branch May 2, 2016 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants