New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@timeout renamed to @delay or @future? #1

Closed
StrikeForceZero opened this Issue Nov 12, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@StrikeForceZero

StrikeForceZero commented Nov 12, 2017

These look great. Haven't tried them out yet.

But when I first read @timeout, my initial intuition made me think of Promise.timeout() used in some promise libraries like bluebird. Since setTimeout has been around since the beginning of JavaScript, I'm not sure if it's appropriate to use @delay or @future. At least it would hint for something to execute in the future, or after a delay.

Just throwing this out there for consideration. Maybe I'm the odd one out.

Not intending to turn this "issue" into a feature request but it could be really cool to see some decorators that worked with async functions as well just like Bluebird's timeout/delay.

@NetanelBasal

This comment has been minimized.

Show comment
Hide comment
@NetanelBasal

NetanelBasal Nov 12, 2017

Owner

Thanks for your feedback. Let's leave this open and see if there are more like you :).

Owner

NetanelBasal commented Nov 12, 2017

Thanks for your feedback. Let's leave this open and see if there are more like you :).

@cgmx

This comment has been minimized.

Show comment
Hide comment
@cgmx

cgmx Nov 13, 2017

I agree with @StrikeForceZero, I'd rename @timeout to @delay. Seeing @timeout makes me think of Promise.timeout().

cgmx commented Nov 13, 2017

I agree with @StrikeForceZero, I'd rename @timeout to @delay. Seeing @timeout makes me think of Promise.timeout().

@bengry

This comment has been minimized.

Show comment
Hide comment
@bengry

bengry commented Nov 15, 2017

+1

@NetanelBasal

This comment has been minimized.

Show comment
Hide comment
@NetanelBasal

NetanelBasal Nov 17, 2017

Owner

Changed to @delay in 1.5.0, thanks, guys.

Owner

NetanelBasal commented Nov 17, 2017

Changed to @delay in 1.5.0, thanks, guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment