New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Spotlight: searching in user homes, bug #543 #7

Open
wants to merge 1 commit into
base: branch-netatalk-3-1
from

Conversation

Projects
None yet
2 participants
@hat001
Member

hat001 commented Nov 6, 2014

Spotlight cannot search in user homes.
When netatalk(8) starts, it sets up paths for Spotlight.
Since user has not logged in yet, nobody sets up home's path.

FIX: Spotlight: searching in user homes, bug #543
Spotlight cannot search in user homes.
When netatalk(8) starts, it sets up paths for Spotlight.
Since user has not logged in yet, nobody sets up home's path.
setenv("XDG_DATA_HOME", _PATH_STATEDIR, 0);
setenv("XDG_CACHE_HOME", _PATH_STATEDIR, 0);
setenv("TRACKER_USE_LOG_FILES", "1", 0);
system(TRACKER_PREFIX "/bin/tracker-control -s");

This comment has been minimized.

@slowfranklin

slowfranklin Nov 6, 2014

Member

Can we avoid calling tracker-control -s for every home mount? This should probably be moved to etc/netatalk/netatalk.c or something similar that ensures we only call out to tracker-control once in order to start it up.

@slowfranklin

slowfranklin Nov 6, 2014

Member

Can we avoid calling tracker-control -s for every home mount? This should probably be moved to etc/netatalk/netatalk.c or something similar that ensures we only call out to tracker-control once in order to start it up.

system(TRACKER_PREFIX "/bin/tracker-control -s");
cmd = bformat("tracker-control -f \"%s\"", path);
LOG(log_debug, logtype_sl, "creatvol: sl (re)indexing home: %s", bdata(cmd));
system(bdata(cmd));

This comment has been minimized.

@slowfranklin

slowfranklin Nov 7, 2014

Member

And another one: will system() return after tracker-control -f scheduled the reindexing or will it wait until the reindexing completed ? If tracker-control -f doesn't exit until the reindexing is complete so would system(), so you may test this by calling tracker-control -f on some big directory tree.

If it turns out that tracker-control -f waits till the indexing completes, the afpd process waiting for the system() command will be stuck there and the AFP session might run into timeouts.

@slowfranklin

slowfranklin Nov 7, 2014

Member

And another one: will system() return after tracker-control -f scheduled the reindexing or will it wait until the reindexing completed ? If tracker-control -f doesn't exit until the reindexing is complete so would system(), so you may test this by calling tracker-control -f on some big directory tree.

If it turns out that tracker-control -f waits till the indexing completes, the afpd process waiting for the system() command will be stuck there and the AFP session might run into timeouts.

@slowfranklin

This comment has been minimized.

Show comment
Hide comment
@slowfranklin

slowfranklin Nov 18, 2014

Member

ping Any progress? You're blocking a bugfix release that actually fixes several severe bugs.

Member

slowfranklin commented Nov 18, 2014

ping Any progress? You're blocking a bugfix release that actually fixes several severe bugs.

@hat001

This comment has been minimized.

Show comment
Hide comment
@hat001

hat001 Nov 19, 2014

Member

Sorry.
I have not started this work since I am busy these days.
If this problem is not solved, this is not a bug but spec.
It must be specified in documents that home cannot be searched by Spotlight.

HAT

Member

hat001 commented Nov 19, 2014

Sorry.
I have not started this work since I am busy these days.
If this problem is not solved, this is not a bug but spec.
It must be specified in documents that home cannot be searched by Spotlight.

HAT

@slowfranklin

This comment has been minimized.

Show comment
Hide comment
@slowfranklin

slowfranklin Nov 19, 2014

Member

If this problem is not solved, this is not a bug but spec.

I disagree. It's a bug that's just not as easy to fix as one might wish.

It must be specified in documents that home cannot be searched by Spotlight.

Patches for the documentation welcome!

Member

slowfranklin commented Nov 19, 2014

If this problem is not solved, this is not a bug but spec.

I disagree. It's a bug that's just not as easy to fix as one might wish.

It must be specified in documents that home cannot be searched by Spotlight.

Patches for the documentation welcome!

@hat001

This comment has been minimized.

Show comment
Hide comment
@hat001

hat001 Nov 19, 2014

Member

Patches for the documentation welcome!

Since you implemented it, you should write the document.

HAT

Member

hat001 commented Nov 19, 2014

Patches for the documentation welcome!

Since you implemented it, you should write the document.

HAT

@slowfranklin

This comment has been minimized.

Show comment
Hide comment
@slowfranklin

slowfranklin Nov 19, 2014

Member

Am 19.11.2014 um 15:40 schrieb HAT notifications@github.com:

Patches for the documentation welcome!

Since you implemented it, you should write the document.

I don't care about user homes and I don't have the time. If you want it fixed or documented you have to do the work. :)=

Member

slowfranklin commented Nov 19, 2014

Am 19.11.2014 um 15:40 schrieb HAT notifications@github.com:

Patches for the documentation welcome!

Since you implemented it, you should write the document.

I don't care about user homes and I don't have the time. If you want it fixed or documented you have to do the work. :)=

@hat001

This comment has been minimized.

Show comment
Hide comment
@hat001

hat001 Nov 20, 2014

Member

I will travel from 21st to 23rd Nov.
Please release 3.1.7.
I will consider it more later.

HAT

Member

hat001 commented Nov 20, 2014

I will travel from 21st to 23rd Nov.
Please release 3.1.7.
I will consider it more later.

HAT

@slowfranklin

This comment has been minimized.

Show comment
Hide comment
@slowfranklin

slowfranklin Nov 21, 2014

Member

Please release 3.1.7.

okey, dokey.

Member

slowfranklin commented Nov 21, 2014

Please release 3.1.7.

okey, dokey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment