Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a Docker image for `riskquant` #7

Open
wants to merge 3 commits into
base: master
from

Conversation

@skuenzli
Copy link

skuenzli commented Feb 12, 2020

I created a Docker image for riskquant so that I could run it inside a container. I had trouble installing riskquant on OSX (Python 3.6 in venv, fwiw), but I succeeded going this route and wanted to share it. Thank you for publishing riskquant!

Here's how to build and run riskquant using Docker. I'm happy to update the README if you're interested in supporting Docker.

Build the image:

docker build -t riskquant .

Run riskquant inside a container:

docker container run --rm -it   -v "$(PWD)/data":/data/  riskquant --file /data/webapp.threat-model.csv

Check the results:

cat data/webapp.threat-model_prioritized.csv
Build the image:
docker build -t riskquant .

Run riskquant inside a container:
docker container run --rm -it   -v "$(PWD)/data":/data/  riskquant --file /data/webapp.threat-model.csv

Check the results:
cat data/webapp.threat-model_prioritized.csv
@snkilmartin

This comment has been minimized.

Copy link
Contributor

snkilmartin commented Feb 21, 2020

Yeah, this is a great idea! I think your notes here would be perfect for the README; if you'll add them here then I will merge this PR.

@skuenzli

This comment has been minimized.

Copy link
Author

skuenzli commented Feb 21, 2020

Super! I will add instructions to the README and update the PR (soon).

@skuenzli

This comment has been minimized.

Copy link
Author

skuenzli commented Feb 22, 2020

@snkilmartin I've updated the PR with instructions for running riskquant with Docker.

I err'd on the side of explaining how the data volume mount works because I suspect many riskquant users may not have much background in Docker, and I'm hoping to head off usage problems.

Naturally, feel free to trim or otherwise adjust what I've provided here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.