Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hystrix exceptions not passed into fallback. #1155

Closed
ckstettler opened this issue Mar 17, 2016 · 8 comments · Fixed by #1167
Closed

Hystrix exceptions not passed into fallback. #1155

ckstettler opened this issue Mar 17, 2016 · 8 comments · Fixed by #1167

Comments

@ckstettler
Copy link

I have implemented a fallback that accepts Throwable.

What I see is the following:

If I get into my @HystrixCommand annotated function and throw an exception, then I do in fact see the correct throwable in the fallback function.

If the exception is raised as part of the @HystrixCommand processing within javanica such as timeout or queue threshold is reached etc, then the throwable in the fallback is not populated.

Is there anyway for me to see these exceptions? I am using 1.5.1.

@mattrjacobs
Copy link
Contributor

@ckstettler Thanks for the report. Can someone more familiar with hystrix-javanica look into this bug?
/cc @dmgcodevil

@dmgcodevil
Copy link
Contributor

Hi, it's a duplicate #974
Problem was getFailedExecutionException() doesn't return exceptions in case of timeouts and etc but nulls. to get exception javanica uses getFailedExecutionException().
I remember Matt fixed this issue in core.
@mattrjacobs should I change something in javanica to get such exceptions and propogate them ?

@mattrjacobs
Copy link
Contributor

@dmgcodevil IIRC, it's the change you mentioned here: #1013 (comment)

@dmgcodevil
Copy link
Contributor

Oh, right, will change today then
On 23 Mar 2016 1:36 p.m., "Matt Jacobs" notifications@github.com wrote:

@dmgcodevil https://github.com/dmgcodevil IIRC, it's the change you
mentioned here: #1013 (comment)
#1013 (comment)


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1155 (comment)

@fayndee
Copy link

fayndee commented Mar 31, 2016

Hi @dmgcodevil, is there any progress on this fix?

@dmgcodevil
Copy link
Contributor

Hi @fayndee, yes, Spencer has fixed the issue. I guess we can close this issue

@mattrjacobs
Copy link
Contributor

Released in 1.4.26/1.5.2

@ckstettler
Copy link
Author

Awesome!! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants